Restore ogmios CLI args on instance container - #90
Merged
Conversation
Commit ce37a59 dropped the ogmios CLI args (--node-socket/--node-config/ --host/--include-cbor) in favor of a NETWORK env var, matching the Blink Labs image entrypoint. That image was a temporary solution; the permanent images are the cardanosolutions-based ext-cardano-ogmios-instance-* builds, whose entrypoint requires those args to reach the node socket. Restore args (local.container_args is still defined) while leaving NETWORK in place so the temporary Blink Labs pods keep working during the transition. This unblocks v7 instances, which use the cardanosolutions-based image. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ce37a59replaced the ogmios CLI args (--node-socket /ipc/node.socket,--node-config /config/config.json,--host 0.0.0.0,--include-cbor) with aNETWORKenv var to match the Blink Labs ogmios image entrypoint. That image was a temporary solution.The permanent images are the
cardanosolutions-basedext-cardano-ogmios-instance-*builds (seedocker/ogmios-5|6|7), whose entrypoint is the rawogmiosbinary and requires those args to reach the socat-tunneled node socket. Without them the container can't connect and won't sync.This restores
args = local.container_argson the instance container (the local is still defined) while leaving theNETWORKenv var in place, so the still-running temporary Blink Labs pods aren't disturbed during the transition.Why now
Needed to deploy v7 instances (which use the cardanosolutions-based
ext-cardano-ogmios-instance-7image, #88). With the currentmain, a v7 instance would come up with no args and fail to connect.Downstream
Clusters can bump the module
refto this commit to deploy v7 with the args model (e.g. them2-prod-7xjh33preprod v7 validation instance).🤖 Generated with Claude Code