Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws eks ciac 10721 #36689

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Aws eks ciac 10721 #36689

wants to merge 40 commits into from

Conversation

YairGlick
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Oct 10, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS-AccessAnalyzer/Integrations/AWS-AccessAnalyzer
   AWS-AccessAnalyzer.py142795%13, 27–28, 30, 54, 56, 157
Packs/AWS-Athena/Integrations/AWS-Athena
   AWS-Athena.py1022971%27, 52, 57, 60, 66, 69, 72, 83, 87, 106–108, 111, 137–138, 140–141, 144–145, 195, 201, 203, 218–219, 221–222, 224–226
Packs/AWS-EC2/Integrations/AWS-EC2
   AWS-EC2.py1968167414%22–23, 34–40, 42, 47, 53–56, 58, 62–64, 68–70, 74–79, 83–94, 96, 101, 118–124, 126–128, 130, 135–136, 138–139, 142, 147–151, 153–155, 160, 170–178, 180, 182–183, 185–191, 202–204, 207–208, 210–211, 213–217, 227–238, 240, 242–243, 245–246, 252, 254–258, 268–271, 273–280, 282, 284–285, 287–288, 295–303, 306–312, 322, 324–326, 328–333, 335, 337–338, 340–341, 347–357, 360–361, 363, 373, 375–377, 379–386, 388, 390–397, 409–411, 415–421, 431, 433–435, 437–440, 442, 444–451, 459–461, 464–470, 480, 482–484, 486–491, 493, 495–502, 512–514, 518–524, 534, 536–538, 540–543, 545, 547–548, 554, 564, 566–568, 570–573, 575, 577–580, 590–592, 596–602, 612, 614–616, 618–621, 623, 625–628, 639–641, 645–651, 661, 663–665, 667–672, 674, 676–679, 688–690, 694–700, 710, 712, 714–715, 721, 730, 732–733, 735–742, 744–745, 751, 761–763, 765–768, 774, 776–779, 781, 793–795, 799–806, 815–819, 826–828, 833–836, 838, 840, 847, 856, 858–861, 866, 868–869, 871–876, 878–879, 881–884, 886, 900–902, 904, 917–918, 922–925, 930–934, 939–943, 948–952, 957–961, 966–970, 975–977, 979–994, 1000, 1002–1005, 1007, 1018–1024, 1028, 1037, 1039, 1044–1049, 1056–1057, 1059, 1072, 1074, 1076–1081, 1083–1088, 1095–1096, 1098, 1111–1115, 1120–1122, 1126–1155, 1157–1164, 1166–1167, 1171–1172, 1176–1177, 1181–1182, 1186–1187, 1190–1191, 1196–1197, 1201–1202, 1204–1211, 1223–1225, 1228–1234, 1244–1253, 1255–1257, 1262–1271, 1273–1275, 1280–1289, 1291–1293, 1298–1307, 1309–1311, 1316–1329, 1331–1333, 1338–1351, 1353–1355, 1360–1363, 1365–1374, 1377–1378, 1386–1390, 1394–1399, 1408–1409, 1414–1415, 1421, 1430–1435, 1437–1440, 1474, 1503–1507, 1509–1513, 1515–1519, 1528, 1536, 1548, 1554–1558, 1560, 1562–1566, 1568, 1573–1574, 1577–1579, 1581–1582, 1584–1585, 1587–1594, 1599–1601, 1606–1613, 1615–1616, 1621, 1631–1633, 1637–1642, 1644–1645, 1650, 1660–1670, 1672, 1674–1675, 1677–1683, 1694–1696, 1699–1700, 1702–1706, 1716–1718, 1720–1721, 1726, 1736–1738, 1740–1741, 1746, 1756–1760, 1765, 1767–1772, 1778, 1791–1796, 1801–1804, 1806–1809, 1814, 1816–1820, 1822–1829, 1831–1832, 1834–1837, 1842–1843, 1845–1846, 1848–1849, 1851, 1858–1861, 1874–1875, 1882–1895, 1897–1900, 1905–1906, 1908–1909, 1911–1912, 1914–1916, 1919–1920, 1923–1924, 1927–1930, 1933–1934, 1938–1939, 1941–1943, 1946–1947, 1950–1951, 1954–1955, 1959–1960, 1962–1963, 1965–1968, 1971–1972, 1975–1976, 1980–1981, 1983, 1985–1990, 1993–1998, 2002–2007, 2011–2016, 2020–2025, 2029–2034, 2038–2039, 2041–2042, 2044–2046, 2049–2050, 2053–2054, 2057–2058, 2061–2062, 2064–2065, 2067–2068, 2070–2071, 2073–2074, 2076–2077, 2079–2086, 2091–2094, 2097–2099, 2108–2118, 2120, 2122–2124, 2130, 2132–2134, 2140, 2142–2146, 2155–2167, 2169, 2171–2173, 2175, 2192–2194, 2197, 2199–2203, 2213–2225, 2227, 2229–2230, 2232–2234, 2241–2243, 2248–2252, 2262–2270, 2273–2274, 2277–2278, 2281–2282, 2285–2286, 2288, 2290, 2295, 2300–2302, 2304, 2306, 2308–2313, 2315–2318, 2320–2321, 2327–2339, 2341–2350, 2352–2387, 2391–2392, 2396–2397, 2401–2402, 2406–2407, 2411–2412, 2416–2421, 2423–2432, 2437–2443, 2447–2448, 2450–2456, 2459–2466, 2468–2470, 2474–2476, 2479–2480, 2483–2484, 2487–2488, 2491–2492, 2496–2497, 2499–2500, 2502–2503, 2505, 2507–2509, 2517–2524, 2533–2541, 2543–2545, 2553, 2555–2559, 2568–2570, 2572–2577, 2579–2583, 2585–2588, 2590–2591, 2593–2602, 2604–2607, 2612–2617, 2619–2622, 2627–2630, 2632–2635, 2640–2643, 2645–2648, 2653–2656, 2658–2661, 2666–2674, 2676, 2678–2681, 2685–2687, 2690–2692, 2696–2697, 2699–2703, 2713–2732, 2734–2741, 2745–2746, 2748–2751, 2765, 2774, 2776–2777, 2779–2789, 2791–2792, 2794, 2803–2808, 2813, 2815–2818, 2820, 2822–2823, 2830–2832, 2852, 2854, 2856, 2858, 2893, 2895, 2897, 2899, 2932, 2939, 2941, 2979, 2981, 2983, 2985, 2987, 2989, 2991, 2993, 2995, 3017, 3019–3020, 3022, 3024–3026, 3028–3030, 3032–3033, 3035–3036, 3038–3039, 3041–3042, 3044–3045, 3047–3048, 3050–3051, 3053–3054, 3056–3057, 3059–3060, 3062–3063, 3065–3066, 3068–3069, 3071–3072, 3074–3075, 3077–3078, 3080–3081, 3083–3084, 3086–3087, 3089–3090, 3092–3093, 3095–3096, 3098–3099, 3101–3102, 3104–3105, 3107–3108, 3110–3111, 3113–3114, 3116–3117, 3119–3120, 3122–3123, 3125–3126, 3128–3129, 3131–3132, 3134–3135, 3137–3138, 3140–3141, 3143–3144, 3146–3147, 3149–3150, 3152–3153, 3155–3156, 3158–3159, 3161–3162, 3164–3165, 3167–3168, 3170–3171, 3173–3174, 3176–3177, 3179–3180, 3182–3183, 3185–3186, 3188–3189, 3191–3192, 3194–3195, 3197–3198, 3200–3201, 3203–3204, 3206–3207, 3209–3210, 3212–3213, 3215–3216, 3218–3219, 3221–3222, 3224–3225, 3227–3228, 3230–3231, 3233–3234, 3236–3237, 3239–3240, 3242–3243, 3245–3246, 3248–3249, 3251–3252, 3254–3255, 3257–3259
Packs/AWS-EKS/Integrations/AWSEKS
   AWSEKS.py1531292%54, 172, 206–208, 210, 274, 312–314, 316, 394
Packs/AWS-GuardDuty/Integrations/AWSGuardDuty
   AWSGuardDuty.py3791695%12–13, 37–38, 40, 260, 345, 378, 380, 382, 390, 394, 419, 441, 445, 715
Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector
   AWSGuardDutyEventCollector.py75297%13, 35
Packs/AWS-IAM/Integrations/AWS-IAM
   AWS-IAM.py2364182%16–19, 21, 42, 402, 874, 881, 913, 920, 970–972, 974, 1003–1004, 1034–1035, 1065–1066, 1094–1095, 1108, 1111, 1114–1115, 1171–1172, 1200–1201, 1229–1230, 1248–1250, 1291–1292, 1297–1299
Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter
   AWSIAMIdentityCenter.py2571195%28–29, 38, 59, 117–118, 127, 210, 656, 662, 664
Packs/AWS-Lambda/Integrations/AWS_Lambda
   AWS_Lambda.py33521336%29, 92–98, 100, 104, 110–113, 115, 119–120, 124, 144–148, 155–156, 158–163, 165, 167–169, 171–174, 176–185, 187, 195–198, 200–202, 209–211, 213–215, 220–222, 224–227, 234, 236–238, 240–242, 247–251, 253–256, 261–268, 273–289, 294–301, 303–304, 314, 318–321, 323–325, 330–334, 347–352, 354–356, 374, 428, 474, 517, 644–647, 649, 735–737, 742–757, 759, 762–800, 802–803
Packs/AWS-Organizations/Integrations/AWSOrganizations
   AWSOrganizations.py2096170%10–11, 130, 175–176, 416–417, 682–684, 686, 688, 690–734, 736, 738–740
Packs/AWS-Route53/Integrations/AWSRoute53
   AWSRoute53.py1162875%21–24, 26, 38–39, 79–80, 115–116, 155–156, 174–175, 205–206, 228–229, 256–257, 263–266, 268, 271–272
Packs/AWS-S3/Integrations/AWS-S3
   AWS-S3.py1453973%21, 32–35, 37, 47, 49, 51, 53, 55, 57, 59, 117, 135, 138–139, 141, 151, 153, 167, 171–172, 176, 179, 181–183, 188, 191–193, 198–199, 227, 230–233
Packs/AWS-SNS/Integrations/AWSSNS
   AWSSNS.py1513676%33, 56–57, 166–172, 177–187, 189, 198–199, 201, 204–210, 216, 218, 220–221
Packs/AWS-SQS/Integrations/AWS-SQS
   AWS-SQS.py18113823%6, 17, 25–28, 30–31, 33–34, 36–37, 41–48, 50–51, 53–54, 58–59, 63–66, 68–69, 73–78, 80–81, 83–84, 88–112, 114–117, 119–120, 124–127, 129–130, 134–137, 139–140, 144–152, 187–189, 213–214, 218–224, 229–242, 244, 253–254, 256, 259–268, 274, 276, 278–279
Packs/AWS-SecurityHub/Integrations/AWSSecurityHubEventCollector
   AWSSecurityHubEventCollector.py771185%12–13, 79, 91, 139, 154–155, 158, 167–168, 193
Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub
   AWS_SecurityHub.py2838569%485–486, 488, 554–555, 641, 645, 652–658, 662, 666–677, 681–689, 698–701, 715–716, 718, 740, 751–752, 754–759, 763, 792–799, 801–806, 829, 839–840, 843–845, 873, 886, 927–928, 995–997, 1004, 1009–1012
Packs/AWS-SecurityLake/Integrations/AWSSecurityLake
   AWSSecurityLake.py1462980%27, 54–55, 57, 78, 80, 98, 103, 106, 112, 115, 118, 130, 135, 154–156, 159, 184, 190, 192, 207–208, 210–215
Packs/AWS_SystemManager/Integrations/AWSSystemManager
   AWSSystemManager.py38510971%11–13, 188–189, 258, 279, 385–388, 523, 617–618, 684, 746–747, 823, 895, 955, 1044, 1081, 1085, 1089, 1093, 1156, 1160, 1165, 1198, 1209, 1256, 1332, 1334–1336, 1339, 1387, 1408–1409, 1412, 1415, 1425–1426, 1468, 1475, 1502–1503, 1507–1510, 1512–1518, 1521–1522, 1524, 1531, 1533, 1546, 1548–1549, 1551–1576, 1578–1594
Packs/AWS_WAF/Integrations/AWSWAF
   AWSWAF.py3108672%11–12, 184, 258, 280, 296, 381–382, 387, 396, 398, 445, 447–450, 452, 498, 500, 556, 574, 623, 625, 681, 699, 744, 820, 822, 838, 840, 842–843, 845, 851, 853, 859, 861, 863–864, 866, 872, 874, 880, 882, 884–885, 887, 893, 895, 901, 903–905, 907, 913, 915, 921–925, 927, 933, 935, 941, 943–946, 948, 954, 957, 963, 965, 967–968, 970, 976, 979, 985, 987, 989–990, 992, 998, 1000
Packs/ApiModules/Scripts/AWSApiModule
   AWSApiModule.py1252084%80–81, 120, 134, 137–139, 141–142, 163, 165, 168, 170, 176–177, 180–181, 238, 260–261
Packs/Aws-SecretsManager/Integrations/AwsSecretsManager
   AwsSecretsManager.py1031882%30–33, 35, 43, 47, 49–50, 76, 78, 80, 82, 84, 123, 125, 133, 168
TOTAL5878266554% 

Tests Skipped Failures Errors Time
160 0 💤 0 ❌ 0 🔥 12.071s ⏱️

@YairGlick YairGlick requested a review from jbabazadeh October 13, 2024 10:07
@kobymeir
Copy link
Contributor

kobymeir commented Dec 3, 2024

This PR is marked as 'Stale' because it has been open for 30 days with no activity, it will be automatically closed in 15 days if no activity will be done. To reset the counter just remove the 'Stale' label or make changes to update this PR. If you wish this PR will never be marked as 'Stale' add the 'Ignore Stale'

@kobymeir kobymeir added the Stale label Dec 3, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kobymeir kobymeir removed the Stale label Dec 4, 2024
@jbabazadeh jbabazadeh self-assigned this Feb 1, 2025
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! please see me comments! and sorry for the delay !

@@ -383,7 +427,7 @@ def update_access_entry_command(aws_client, args: dict) -> CommandResults:
)


def test_module(aws_client) -> str:
def test_module() -> str: # pragma: no cover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can add unit test

@@ -65,6 +98,7 @@ def list_clusters_command(aws_client, args: dict) -> CommandResults:
Returns:
A Command Results object
"""
aws_client = build_client(args)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to call this on each command and not create the client in the main and send as param?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client needs to be built inside the function to support the @run_on_all_accounts decorator, which requires a separate session for each account.


##### AWS - ACM

- Documentation and metadata improvements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure this should be the RN lets think together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it more appropriate now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants