Update for Pack: Gatewatcher AionIQ

[clement-lyonnet]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

None

Description

Update for GCenter103 integration.
Add commands to this integration to interact with the GCenter API.
Updated layouts to display indicators of incidents.

Must have

• Tests
• Documentation

[clement-lyonnet]

Hi @ilaredo and the documentation team,

Thanks for your indications, I tried to apply the requested changes.

However, I am not able to generate unit tests files using this command:
demisto-sdk generate-unit-tests -i Packs/Gatewatcher-AionIQ/Integrations/GCenter103/GCenter103.py -e Packs/Gatewatcher-AionIQ/Integrations/GCenter103/command_examples.txt --insecure -a

Am I missing something?

[ilaredo]

What is the failure reason?

[clement-lyonnet]

2025-02-12 10:56:18.209 | INFO |
Running code parser and testing generator. @ generate_unit_tests.py:360 (function)
2025-02-12 10:56:18.210 | DEBUG | Starting parsing input code into ast. @ generate_unit_tests.py:361 (function)
2025-02-12 10:56:18.456 | DEBUG | Finished parsing code into ast. @ generate_unit_tests.py:363 (function)
2025-02-12 10:56:20.503 | INFO | Running solver for test generating. @ generate_unit_tests.py:366 (function)
2025-02-12 10:56:20.506 | DEBUG | Obtaining client class ast. @ generate_unit_tests.py:221 (function)
2025-02-12 10:56:20.506 | INFO | An error occurred: ("'NoneType' object has no attribute 'name'",) @ generate_unit_tests.py:348 (function)

[ilaredo]

can you add the latest logs file? it should be at ./Users/username/.demisto-sdk/logs
I hope this issue is quick to fix but always it is possible to write it manually:)

[clement-lyonnet]

I think this is the one you asked

demisto_sdk_debug.log

[ilaredo]

Hi @clement-lyonnet,
I wanted to inform you that the issue is not a quick fix and will require some time to resolve. If you are able to, please consider writing the code for the unit test yourself. Alternatively, if you prefer not to, then please await the resolution of the issue.

Thank you for your understanding.

[content-bot]

For the Reviewer: Trigger build request has been accepted for this contribution PR.

[content-bot]

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2492823

[content-bot]

For the Reviewer: Trigger build request has been accepted for this contribution PR.

[content-bot]

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2531224

[ilaredo]

Hi @clement-lyonnet,
I haven't heard from you for a while. How is the unit test writing going on? do you need help?

[clement-lyonnet]

Hi @ilaredo, I have tried to push unit tests, it passes pytest command locally and here on the PR.
However, in the PR pipeline it displays the following message: Unit-tests for 'Packs/Gatewatcher-AionIQ/Integrations/GCenter103/GCenter103.py' must reach a coverage of at least 69.39 percent (currently: 63.29 percent).
Let me know if I have to modify things :)

[ilaredo]

To improve your code quality, you should increase the number of unit tests. The threshold for code coverage is set at 69.39%, which means that almost 70% of your code should be covered by unit tests. Therefore, make sure to test all functions and parts of the code that have not been tested yet.
Please see here about unit testing.
How to write unit test
Good example for unit tests: Proofpoint TAP v2 integration
And also, dont forget to remove all your # noqa: F405 from your code which will make you cover all these commands with unit tests

[ilaredo]

Hi @clement-lyonnet ,
Have you reached the coverage threshold?
Also, I see that the pre-commit is still failing. Please let me know about the progress of this PR and if you need any help. I'll take a look at it!

[content-bot]

For the Reviewer: Trigger build request has been accepted for this contribution PR.

[content-bot]

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2637509

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ clement-lyonnet
❌ amshamah419
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[clement-lyonnet]

Hi @ilaredo, sorry for the response delay. We are currently under functionnal tests after discovering an unexpected behavior. In addition, we are working with the unit tests. We will update the PR as soon as possible