Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mock from conf json and test upload #38562

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove mock from conf json and test upload #38562

wants to merge 4 commits into from

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Feb 10, 2025 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11016

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Feb 10, 2025
@MosheEichler MosheEichler requested review from tkatzir and removed request for kobymeir, thefrieddan1, DeanArbel and sapirshuker March 3, 2025 09:11
@MosheEichler MosheEichler changed the title Remove mock from conf json Remove mock from conf json and test upload Mar 3, 2025
@MosheEichler
Copy link
Contributor Author

Needs a force merge
Failure

pydantic.error_wrappers.ValidationError: 1 validation error for ConfJSON
unmockable_integrations
  field required (type=value_error.missing)

This is by purpose

@MosheEichler MosheEichler added the ForceMerge Forcing the merge of the PR despite the build status label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatzir tkatzir tkatzir approved these changes

Assignees

@MosheEichler MosheEichler

Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MosheEichler @tkatzir