Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DomainTools Enterprise Integrations #38725

Conversation

briluza
Copy link
Contributor

@briluza briluza commented Feb 21, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Deprecate the DomainTools Enterprise Pack, use the DomainTools Iris Pack instead.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2025

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 21, 2025
@content-bot content-bot changed the base branch from master to contrib/DomainTools_deprecate-domaintools-enterprise-integrations February 21, 2025 09:09
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @inbalapt1 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @briluza, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@inbalapt1
Copy link
Contributor

Hi @briluza
Thank you for your contribution! We really appreciate it. 🚀

Please add release-notes using this page.
Thanks!

@briluza
Copy link
Contributor Author

briluza commented Feb 28, 2025

Hi @inbalapt1, added release notes. 😄

Copy link
Contributor

@inbalapt1 inbalapt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the following command: demisto-sdk format --deprecate,
and update the pack_metadata with my suggestion.
Thanks!

@briluza briluza requested a review from sapirshuker as a code owner March 3, 2025 15:35
@inbalapt1 inbalapt1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Mar 3, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2625587

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Mar 3, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2625592

@inbalapt1
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@inbalapt1 inbalapt1 self-requested a review March 4, 2025 09:50
@inbalapt1 inbalapt1 added the ForceMerge Forcing the merge of the PR despite the build status label Mar 4, 2025
@DeanArbel DeanArbel merged commit 4862340 into demisto:contrib/DomainTools_deprecate-domaintools-enterprise-integrations Mar 4, 2025
25 of 26 checks passed
Copy link

github-actions bot commented Mar 4, 2025

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR ForceMerge Forcing the merge of the PR despite the build status Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants