Syakima/CIAC-15740/forcepoint-add-refresh-command by TheL0L · Pull Request #43628 · demisto/content

TheL0L · 2026-03-23T16:26:12Z

Related Issues

fixes: CIAC-15740

Description

Add polling command for refreshing engines.

content-bot · 2026-03-23T16:27:48Z

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

@marketplace-ai-reviewer start review - Initiate a full AI code review
@marketplace-ai-reviewer re-review - Incremental review for new commits

…command

github-actions · 2026-03-25T12:45:49Z

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/ForcepointSecurityManagementCenter/Integrations/ForcepointSecurityManagementCenter
ForcepointSecurityManagementCenter.py	408	94	76%	41–44, 48–49, 53, 61–62, 67–68, 118, 124, 146–151, 153–154, 262, 264, 331, 411, 413, 497, 499, 611, 613, 654, 708, 783, 785, 787, 911–917, 919–924, 926, 928–969, 971–972, 974
TOTAL	408	94	76%

Tests	Skipped	Failures	Errors	Time
39	0 💤	0 ❌	0 🔥	2.572s ⏱️

…command

marketplace-ai-reviewer · 2026-03-25T13:01:14Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-03-25T13:25:02Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

Thanks for your contribution to the Forcepoint SMC integration! I've reviewed the PR and found a few logic and configuration adjustments needed.

Specifically, please ensure demisto.args() isn't evaluated at module load time, verify task success statuses when polling finishes, and fix the CommandResults initialization to use readable_output instead of outputs_prefix. You'll also need to align the task_ids argument name between the YAML and Python script, store it as a comma-separated string to avoid serialization issues, and update the pack metadata with the required XSOAR fields.

Let me know if you have any questions about these changes!

Additionally, please address the following file-level notes:

Packs/ForcepointSecurityManagementCenter/pack_metadata.json: - The url field must be set to https://www.paloaltonetworks.com/cortex for XSOAR-supported packs.
The vendor name 'Forcepoint' must be included in the keywords list.
The mandatory created key is missing from the pack metadata.

@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

marketplace-ai-reviewer · 2026-03-25T13:24:59Z

+        demisto.debug("Completed task initiation.")
+        demisto.debug(f"Initiated refresh tasks for engines {', '.join(engine_names)}.")
+        demisto.debug(f"Tasks IDs: {task_ids}")
+        args["task_ids"] = task_ids


Store task_ids as a comma-separated string to avoid serialization issues.

@TheL0L I would also recommend doing this (also ensures the order is kept and not changed).

@kamalq97 Can we guarantee that the ids will not have commas within them, and if they do - escape them?

marketplace-ai-reviewer · 2026-03-25T13:24:59Z

+    assert result.scheduled_command._command == "forcepoint-smc-engine-refresh"
+    assert result.scheduled_command._args is not None
+    assert "task_ids" in result.scheduled_command._args
+    assert result.scheduled_command._args["task_ids"] == ["engine1", "engine2"]


Update test to expect a comma-separated string.

marketplace-ai-reviewer · 2026-03-25T13:24:59Z

+    assert result.scheduled_command._command == "forcepoint-smc-engine-refresh"
+    assert result.scheduled_command._args is not None
+    assert "task_ids" in result.scheduled_command._args
+    assert result.scheduled_command._args["task_ids"] == ["engine1"]


Update test to expect a comma-separated string.

kamalq97

@TheL0L Great job! Ensure all comments from me and the @marketplace-ai-reviewer are addressed. Please also fix all validation errors.
Once done, we'll proceed to the next steps.

kamalq97 · 2026-03-25T15:00:34Z

+        demisto.debug("Completed task initiation.")
+        demisto.debug(f"Initiated refresh tasks for engines {', '.join(engine_names)}.")
+        demisto.debug(f"Tasks IDs: {task_ids}")
+        args["task_ids"] = task_ids


@TheL0L I would also recommend doing this (also ensures the order is kept and not changed).

Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>

content-bot · 2026-03-26T12:17:18Z

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

julieschwartz18

@TheL0L Doc review complete. Please check the comments and also regenerate the integration README file. In the meantime, adding the label docs-approved

Co-authored-by: julieschwartz18 <91824591+julieschwartz18@users.noreply.github.com>

content-bot · 2026-05-15T00:36:22Z

This PR is marked as 'Stale' because it has been open for 30 days with no activity, it will be automatically closed in 15 days if no activity will be done. To reset the counter just remove the 'Stale' label or make changes to update this PR. If you wish this PR will never be marked as 'Stale' add the 'Ignore Stale'

TheL0L added 3 commits March 23, 2026 17:45

add polling command for refreshing engines

7fb2d0b

update documentaion

5906a79

add release notes

b2d5c48

TheL0L self-assigned this Mar 23, 2026

TheL0L and others added 3 commits March 25, 2026 11:09

fix markdown linter errors

6e0aa68

add unit tests for new command

91b8786

Merge branch 'master' into syakima/CIAC-15740/forcepoint-add-refresh-…

39e1bf3

…command

add release notes

c03754f

TheL0L requested a review from kamalq97 March 25, 2026 12:54

TheL0L added python Pull requests that update Python code ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Mar 25, 2026

Merge branch 'master' into syakima/CIAC-15740/forcepoint-add-refresh-…

58b6b0e

…command

marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Mar 25, 2026

marketplace-ai-reviewer reviewed Mar 25, 2026

View reviewed changes

address suggestion

084b359

kamalq97 added enhancement ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Mar 25, 2026

kamalq97 requested changes Mar 25, 2026

View reviewed changes

TheL0L and others added 4 commits March 26, 2026 13:32

Apply suggestion from @kamalq97

54c1d9a

Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>

address suggestions

c2a413a

update docker image

cae8dbd

add missing sectionorder and section keys

8ecc2de

TheL0L requested a review from richardbluestone April 13, 2026 09:08

richardbluestone requested review from julieschwartz18 and removed request for richardbluestone April 13, 2026 11:02

julieschwartz18 reviewed Apr 13, 2026

View reviewed changes

julieschwartz18 added the docs-approved label Apr 13, 2026

TheL0L and others added 2 commits April 14, 2026 14:48

Apply suggestions from docs review

4823b12

Co-authored-by: julieschwartz18 <91824591+julieschwartz18@users.noreply.github.com>

update readme

fda412d

content-bot added the Stale label May 15, 2026

Conversation

TheL0L commented Mar 23, 2026

Related Issues

Description

Uh oh!

content-bot commented Mar 23, 2026

🤖 AI-Powered Code Review Available

Uh oh!

github-actions Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marketplace-ai-reviewer commented Mar 25, 2026

Uh oh!

marketplace-ai-reviewer commented Mar 25, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marketplace-ai-reviewer Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

kamalq97 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

TheL0L Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kamalq97 left a comment

Choose a reason for hiding this comment

Uh oh!

kamalq97 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

content-bot commented Mar 26, 2026

Uh oh!

julieschwartz18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

content-bot commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Mar 25, 2026 •

edited

Loading