Skip to content

New collector - Menlo Security#44002

Open
RosenbergYehuda wants to merge 30 commits into
masterfrom
YR/New-collector--Menlo-Security/CIAC-16573
Open

New collector - Menlo Security#44002
RosenbergYehuda wants to merge 30 commits into
masterfrom
YR/New-collector--Menlo-Security/CIAC-16573

Conversation

@RosenbergYehuda
Copy link
Copy Markdown
Contributor

@RosenbergYehuda RosenbergYehuda commented Apr 23, 2026

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-16575

Description

A new collector

Must have

  • Tests
  • Documentation

@RosenbergYehuda RosenbergYehuda self-assigned this Apr 23, 2026
@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/MenloSecurity/Integrations/MenloSecurity
   MenloSecurity.py2664881%78, 80–82, 150, 234–235, 269–270, 300, 370, 417–419, 471–472, 480–481, 516, 518, 555–557, 559–563, 565–566, 571, 573–574, 576–577, 579–582, 589–591, 593–594, 601, 603–605
TOTAL2664881% 

Tests Skipped Failures Errors Time
41 0 💤 0 ❌ 0 🔥 9.652s ⏱️

@guardrails
Copy link
Copy Markdown

guardrails Bot commented Apr 25, 2026

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@RosenbergYehuda RosenbergYehuda marked this pull request as ready for review April 27, 2026 12:56
@RosenbergYehuda RosenbergYehuda added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 27, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 27, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer

This comment was marked as outdated.

@content-bot

This comment has been minimized.

@content-bot

This comment has been minimized.

@content-bot

This comment has been minimized.

@content-bot

This comment has been minimized.

@RosenbergYehuda RosenbergYehuda added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 13, 2026
@RosenbergYehuda
Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 13, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing the Menlo Security integration! I've reviewed your PR and found a few areas for improvement, primarily around error logging, YAML configuration, and documentation.

  • Python Code: Please include full tracebacks in your error logs for better debugging, and avoid excessive debug logging inside loops.
  • YAML & Metadata: Ensure standard key ordering (e.g., name and display at the top), follow the vendor-entity-action naming convention for commands, and add the missing created key to the pack metadata.
  • Documentation: Update the description with steps to obtain the API Auth Token, and regenerate the README using the demisto-sdk to fix MDX formatting issues and parameter mismatches.

Let me know if you have any questions!

@DanielTal87, @marketplace-ai-reviewer, @RosenbergYehuda please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/MenloSecurity.py
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/MenloSecurity.py Outdated
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/MenloSecurity.py Outdated
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/MenloSecurity.py Outdated
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/MenloSecurity.py
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/README.md Outdated
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/README.md Outdated
Comment thread Packs/MenloSecurity/Integrations/MenloSecurity/README.md
Comment thread Packs/MenloSecurity/pack_metadata.json
Comment thread Packs/MenloSecurity/.secrets-ignore
@content-bot

This comment has been minimized.

@content-bot

This comment has been minimized.

@content-bot

This comment has been minimized.

# web: 1 dup removed, 1 new event kept. audit: 1 event (no dedup on first fetch).
assert len(events) == 2
domains = {e.get("domain") for e in events if "domain" in e}
assert "fresh.example.com" in domains
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BC117 (Approved).
✅ BC117 validation has been approved by PM review (supported-modules-approved label present).
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 514d02977e66077d

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants