Skip to content

Added dependson for wrapper scripts#44015

Open
inbalapt1 wants to merge 87 commits into
masterfrom
test-validate-sc110
Open

Added dependson for wrapper scripts#44015
inbalapt1 wants to merge 87 commits into
masterfrom
test-validate-sc110

Conversation

@inbalapt1
Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/CRTX-233892
https://jira-dc.paloaltonetworks.com/browse/CRTX-233534

Description

Added SC110 validation for the dependson field in wrapper scripts, and updated the actions’ wrapper scripts to include dependson.

Must have

  • Tests
  • Documentation

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/SearchIndicatorRelationshipsAgentix
   SearchIndicatorRelationshipsAgentix.py61985%46–47, 126–127, 129–130, 142, 150–151
Packs/CommonScripts/Scripts/SearchIndicatorAgentix
   SearchIndicatorAgentix.py89396%60–61, 139
Packs/CommonScripts/Scripts/SetIndicatorAgentix
   SetIndicatorAgentix.py54492%84–87
Packs/Core/Scripts/CoreIsolateEndpoint
   CoreIsolateEndpoint.py8275%9–10
Packs/Core/Scripts/CoreQuarantineFiles
   CoreQuarantineFiles.py8275%9–10
Packs/Core/Scripts/CoreTerminateCausality
   CoreTerminateCausality.py8275%9–10
Packs/Core/Scripts/CoreTerminateProcess
   CoreTerminateProcess.py8275%9–10
Packs/Core/Scripts/CoreUnisolateEndpoint
   CoreUnisolateEndpoint.py8275%9–10
Packs/Core/Scripts/DiagnoseSyslogCollector
   DiagnoseSyslogCollector.py881780%29–31, 104–106, 160–162, 164–165, 167–172
Packs/Core/Scripts/SearchIndicatorInEventsAgentix
   SearchIndicatorInEventsAgentix.py9277%10–11
Packs/CrowdStrikeFalcon/Scripts/CsFalconLiftHostContainment
   CsFalconLiftHostContainment.py8275%9–10
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpEndpoint
   MicrosoftAtpEndpoint.py9277%11–12
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpIsolateMachine
   MicrosoftAtpIsolateMachine.py8275%9–10
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpScIndicatorCreate
   MicrosoftAtpScIndicatorCreate.py8275%9–10
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpStopAndQuarantineFile
   MicrosoftAtpStopAndQuarantineFile.py8275%9–10
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpUnisolateMachine
   MicrosoftAtpUnisolateMachine.py8275%9–10
Packs/MicrosoftGraphMail/Scripts/MsGraphMailDeleteEmail
   MsGraphMailDeleteEmail.py8275%9–10
Packs/PAN-OS/Scripts/PANOSQueryLogs
   PANOSQueryLogs.py270100% 
TOTAL4255986% 

Tests Skipped Failures Errors Time
25 0 💤 0 ❌ 0 🔥 7.582s ⏱️

@inbalapt1 inbalapt1 added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 26, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 26, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution. I've reviewed your changes and found a few minor metadata and formatting issues to address. Specifically, several packs are missing the vendor name in their keywords list, the Core pack metadata is missing the created key, and a couple of release notes need to be updated to use approved prefixes. Let me know if you have any questions!

Additionally, please address the following file-level notes:

  • Packs/Base/pack_metadata.json: The vendor name (e.g., 'Cortex XSOAR') is missing from the keywords list.
  • Packs/CommonScripts/pack_metadata.json: The vendor name (e.g., 'Cortex XSOAR') is missing from the keywords list.
  • Packs/Core/pack_metadata.json: - The mandatory key created is missing from the pack metadata.
  • The vendor name (e.g., 'Cortex XSOAR') is missing from the keywords list.
  • Packs/MicrosoftDefenderAdvancedThreatProtection/pack_metadata.json: The vendor name ('Microsoft') is missing from the keywords list.
  • Packs/MicrosoftGraphMail/pack_metadata.json: The vendor name ('Microsoft') is missing from the keywords list.
  • Packs/PAN-OS/pack_metadata.json: The vendor name ('Palo Alto Networks') is missing from the keywords list.

@noydavidi, @JudahSchwartz, @dantavori, @talzich, @inbalapt1 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/CommonScripts/ReleaseNotes/1_22_1.md Outdated
Comment thread Packs/Core/ReleaseNotes/3_5_38.md Outdated
@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • PAN-OS pack version was bumped to 2.6.32.
  • MicrosoftGraphMail pack version was bumped to 1.7.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • MicrosoftGraphMail pack version was bumped to 1.7.27.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • CrowdStrikeFalcon pack version was bumped to 2.10.2.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

1 similar comment
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

This comment has been minimized.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.41.84.
  • CommonScripts pack version was bumped to 1.22.12.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

This comment has been minimized.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.5.47.
  • CommonScripts pack version was bumped to 1.22.13.
  • Base pack version was bumped to 1.41.85.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

This comment has been minimized.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.22.14.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.5.48.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

1 similar comment
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.5.49.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 26759b42272a2e11

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants