Skip to content

Sentinel Lookback Mechanism#44282

Open
noydavidi wants to merge 17 commits into
masterfrom
sentinel-lookback-mechanism
Open

Sentinel Lookback Mechanism#44282
noydavidi wants to merge 17 commits into
masterfrom
sentinel-lookback-mechanism

Conversation

@noydavidi
Copy link
Copy Markdown
Contributor

Added a lookback mechanism for fetching incidents.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: link to the issue

Must have

  • Tests
  • Documentation

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AzureSentinel/Integrations/AzureSentinel
   AzureSentinel.py8147291%473, 475, 536, 538, 543, 553, 555, 560, 568, 575, 785–786, 788–790, 792, 822, 864, 871–872, 947–950, 952–953, 1097–1099, 1289–1290, 1404–1405, 1409–1411, 1419, 1421, 1423, 1425, 1431, 1512, 1607–1610, 1614, 1628–1632, 1640, 1644, 1772, 1777, 1898, 1905–1907, 1915–1916, 1965, 2432, 2437, 2495, 2499, 2501, 2503, 2505, 2510–2511
TOTAL8147291% 

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 3.934s ⏱️

@content-bot

This comment has been minimized.

@noydavidi noydavidi marked this pull request as ready for review May 13, 2026 07:24
@noydavidi noydavidi requested a review from dantavori as a code owner May 13, 2026 07:24
@noydavidi noydavidi removed the request for review from dantavori May 13, 2026 07:24
@noydavidi noydavidi added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label May 13, 2026
@noydavidi noydavidi requested a review from MLainer1 May 13, 2026 07:24
@noydavidi noydavidi added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 13, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 13, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@noydavidi
Copy link
Copy Markdown
Contributor Author

image

@noydavidi noydavidi self-assigned this May 13, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution to the Azure Sentinel integration.

I've reviewed the PR and noticed a few architectural risks with the new lookback mechanism, specifically around potential incident drops, state size limits, and incorrect last_fetch_time advancement. There are also some minor YAML formatting tweaks needed, and the documentation should be simplified and updated using demisto-sdk generate-docs.

Let me know if you have any questions or need help adjusting the lookback logic!

Additionally, please address the following file-level notes:

  • Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.yml: The .yml file must start with name or display as the first key at the root level.

@MLainer1, @noydavidi please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.yml Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel_description.md Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel_description.md Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/README.md Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/README.md Outdated
@noydavidi noydavidi removed the request for review from MLainer1 May 13, 2026 08:26
@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • AzureSentinel pack version was bumped to 1.6.3.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

This comment has been minimized.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: cde20ced606bc0ba

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@noydavidi noydavidi requested a review from Shellyber May 14, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants