ServiceNow MCP#44291
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
itssapir
added
ready-for-pipeline-running
marketplace-ai-reviewer
removed
the
ready-for-ai-review
Coverage Report
|
||||||||||||||||||||||||||||||
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for contributing the ServiceNow MCP integration! I've reviewed the PR and noted a few structural and documentation adjustments to make before we can merge. Most importantly, please ensure the YAML file has the name and display keys at the very top, update pack_metadata.json with the missing required fields, and run demisto-sdk generate-docs to populate the missing command examples in the README. Let us know if you have any questions!
Additionally, please address the following file-level notes:
Packs/ServiceNowMCP/Integrations/ServiceNowMCP/ServiceNowMCP_description.md: Consider adding a Troubleshooting section to help users resolve common setup issues.
@itssapir please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| else: | ||
| raise NotImplementedError(f"Command {command} is not implemented") | ||
|
|
||
| except BaseException as eg: |
There was a problem hiding this comment.
Use Exception instead of BaseException.
|
|
||
| except BaseException as eg: | ||
| root_msg = extract_root_error_message(eg) | ||
| return_error(f"Failed to execute {command} command.\nError:\n{root_msg}") |
There was a problem hiding this comment.
Add traceback logging for comprehensive error tracking.
| @@ -0,0 +1,71 @@ | |||
| category: IT Services | |||
There was a problem hiding this comment.
CRITICAL: The first key defined at the root level of the .yml file must always be name or display.
Please move name and display from lines 41-42 to the top of the file.
| description: Retrieves a list of available tools in the ServiceNow MCP server. | ||
| name: list-tools | ||
| hidden: true | ||
| outputs: [] |
There was a problem hiding this comment.
Can context outputs be defined for this command?
| description: Calls a specific tool on the ServiceNow MCP server with optional input parameters. | ||
| name: call-tool | ||
| hidden: true | ||
| outputs: [] |
There was a problem hiding this comment.
Can context outputs be defined for this command?
|
|
||
| #### Input | ||
|
|
||
| | **Argument Name** | **Description** | **Required** | |
There was a problem hiding this comment.
The input table is empty. It should be replaced with the standard text indicating no input arguments. Additionally, this command (and others in this file) is missing the standard #### Command example and #### Human Readable Output sections.
Please apply the suggestion below to fix the empty table (and remove the table separator on line 32), and then run the demisto-sdk generate-docs command to automatically generate the missing sections with proper formatting, examples, and context output.
| | **Argument Name** | **Description** | **Required** | | |
| There are no input arguments for this command. |
To regenerate the documentation, run:
demisto-sdk generate-docs --insecure -e Packs/ServiceNowMCP/Integrations/ServiceNowMCP/command_examples.txt -i Packs/ServiceNowMCP/Integrations/ServiceNowMCP/ServiceNowMCP.ymlFor more details, refer to the Command Examples - Integration Documentation guidelines.
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
The mandatory created field is missing.
| ], | ||
| "tags": [], | ||
| "useCases": [], | ||
| "keywords": [], |
There was a problem hiding this comment.
The vendor name should be included in the keywords list.
| "tags": [], | ||
| "useCases": [], | ||
| "keywords": [], | ||
| "marketplaces": [ |
There was a problem hiding this comment.
The marketplaces array is missing marketplacev2.
| @@ -0,0 +1 @@ | |||
| https://myinstance.service-now.com | |||
There was a problem hiding this comment.
The .secrets-ignore file should contain domain names, not full URLs. Please remove the https:// prefix.
| https://myinstance.service-now.com | |
| myinstance.service-now.com |
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
3 participants
Status
Related Issues
fixes: CRTX-225695
Description
New MCP integration for ServiceNow
Must have