Connectus split packs routing - #5483
Open
israelpoli wants to merge 28 commits into
Open
Conversation
🚫 SDK Nightly requiredThis PR modifies files that require the SDK Nightly pipeline to be run before it can be merged:
Required action:
Alternative: run a Content build instead of the full SDK Nightly (click to expand)If your change is scoped (e.g. a single new validator or a small bug fix), you can run a Content build against this SDK branch instead of the full SDK Nightly pipeline. When your change is a new validator, make sure it is registered in the Content repo's This check will re-run automatically when a label is added or removed. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
… pack and its derived twin
Derived (split) packs were assigned source = <original pack name>, which is
the Managed Content feature directory:
<bucket>/<bucket_path>/<source>/<pack_id>/. A derived Gmail pack therefore
landed under the "Gmail" feature instead of "connectus".
Introduce resolve_derived_pack_source() as the single source of truth, with
precedence: per-pack derived_source in pack_metadata.json > DERIVED_PACK_SOURCE
env var > DEFAULT_DERIVED_PACK_SOURCE ("connectus"). The env var is read per
call rather than at import (unlike ENABLE_SPLIT_PACKS) so it stays testable and
settable by CI.
derived_source is declared in both metadata models because StrictPackMetadata
sets extra = Extra.forbid, which would otherwise reject the field outright.
The link back to the originating pack is unaffected; it is carried by
derived_from.
|
Changelog(s) in markdown:
|
Collaborator
Coverage Report for CI Build 32958811761Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 86.693%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
…rectory write_pack_destinations now accepts the artifacts and managed artifacts directories used by ContentDTO.dump(), so each recorded artifact_path points at the directory packs are actually dumped into instead of the directory holding the JSON file. Managed packs are routed to the managed artifacts directory, and the final path segment is delegated to the same _artifact_path() helper dump() uses.
|
Changelog(s) in markdown:
|
| source_platform: Optional[str] = Field(None, alias="source:platform") | ||
|
|
||
| @root_validator | ||
| def validate_coupling_overrides(cls, values): |
| The ``(source_pack_id, target_pack_id)`` pairs of the pack-level | ||
| dependencies that were deleted. | ||
| """ | ||
| ... |
| def obtain_invalid_content_items_using_graph( | ||
| self, content_items: Iterable[ContentTypes], validate_all_files: bool | ||
| ) -> List[ValidationResult]: | ||
| content_id_to_objects = {item.object_id: item for item in content_items} |
…acks-routing' of github.com:demisto/demisto-sdk into connectus-split-packs-routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST