Skip to content

Commit

Permalink
Fully remove #before_initialize and #after_initialize
Browse files Browse the repository at this point in the history
  • Loading branch information
vickash committed Sep 23, 2024
1 parent a466653 commit e146fe3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
4 changes: 0 additions & 4 deletions lib/denko/behaviors/component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,9 @@ def unregister
# Behaviors::Component only requires a board.
# Include modules from Setup or override this to use pins.
#
def before_initialize(options={}); end
def convert_pins(options={}); end
def initialize_pins(options={}); end
alias :initialize_pin :initialize_pins

# Override in components. Call super when inheriting or mixing in.
def after_initialize(options={}); end
end
end
end
14 changes: 6 additions & 8 deletions test/digital_io/rotary_encoder_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,34 @@ def test_resets_on_initialize

def test_sets_debounce_time_for_both_pins
a_mock = Minitest::Mock.new.expect(:call, nil, [1])
a_mock.expect(:call, nil, [2])
b_mock = Minitest::Mock.new.expect(:call, nil, [1])
b_mock.expect(:call, nil, [2])

part.a.stub(:debounce_time=, a_mock) do
part.b.stub(:debounce_time=, b_mock) do
part.send(:run_after_initialize_cbs)
part.send(:after_initialize, debounce_time: 2)
end
end
a_mock.verify
b_mock.verify
end

def test_calls_listen_on_both_pins_with_given_divider
a_mock = Minitest::Mock.new.expect(:call, nil, [1])
a_mock.expect(:call, nil, [2])
b_mock = Minitest::Mock.new.expect(:call, nil, [1])
b_mock.expect(:call, nil, [2])

part.a.stub(:listen, a_mock) do
part.b.stub(:listen, b_mock) do
part.send(:after_initialize)
part.send(:after_initialize, divider: 2)
part.send(:run_after_initialize_cbs)
end
end
a_mock.verify
b_mock.verify
end

def test_observes_on_initialize
mock = Minitest::Mock.new.expect(:call, nil)
part.stub(:observe_pins, mock) do
part.send(:after_initialize)
part.send(:run_after_initialize_cbs)
end
end

Expand Down

0 comments on commit e146fe3

Please sign in to comment.