fix(crypto): normalize P-521 SPKI exports#34087
Open
fibibot wants to merge 1 commit into
Open
Conversation
Member
|
@fibibot which issue does this fix? It isn't the issue you linked... |
Contributor
|
You are right. I initially linked the inbox tracking issue and had the wrong branch contents on this PR. I replaced the PR with the actual fix for #34044, which was the issue from your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34044
This normalizes imported compressed P-521 EC public keys when exporting SPKI, matching Node.js output for
crypto.subtle.exportKey("spki"). It also removes the stale WPT expected-failure entries for the P-521 compressed import cases that now pass.Closes bartlomieju/orchid-inbox#91
Tests:
deno eval 'JSON.parse(Deno.readTextFileSync("tests/wpt/runner/expectations/WebCryptoAPI.json")); console.log("ok")'deno fmt --check tests/wpt/runner/expectations/WebCryptoAPI.json tests/unit/webcrypto_test.tsdeno lint tests/unit/webcrypto_test.tscargo fmt --check -p deno_cryptocargo check -p deno_crypto