Skip to content

fix(crypto): normalize P-521 SPKI exports#34087

Open
fibibot wants to merge 1 commit into
mainfrom
orch/issue-91
Open

fix(crypto): normalize P-521 SPKI exports#34087
fibibot wants to merge 1 commit into
mainfrom
orch/issue-91

Conversation

@fibibot
Copy link
Copy Markdown
Contributor

@fibibot fibibot commented May 15, 2026

Fixes #34044

This normalizes imported compressed P-521 EC public keys when exporting SPKI, matching Node.js output for crypto.subtle.exportKey("spki"). It also removes the stale WPT expected-failure entries for the P-521 compressed import cases that now pass.

Closes bartlomieju/orchid-inbox#91

Tests:

  • deno eval 'JSON.parse(Deno.readTextFileSync("tests/wpt/runner/expectations/WebCryptoAPI.json")); console.log("ok")'
  • deno fmt --check tests/wpt/runner/expectations/WebCryptoAPI.json tests/unit/webcrypto_test.ts
  • deno lint tests/unit/webcrypto_test.ts
  • cargo fmt --check -p deno_crypto
  • cargo check -p deno_crypto

@lunadogbot lunadogbot changed the title @bartlomieju: Fix the issue in the PR. fix(node): expose internal/webstreams/adapters and util to require() May 15, 2026
@bartlomieju
Copy link
Copy Markdown
Member

@fibibot which issue does this fix? It isn't the issue you linked...

@lunadogbot
Copy link
Copy Markdown
Contributor

You are right. I initially linked the inbox tracking issue and had the wrong branch contents on this PR.

I replaced the PR with the actual fix for #34044, which was the issue from your @fibibot please fix comment. The PR body now links that issue directly.

@lunadogbot lunadogbot changed the title fix(node): expose internal/webstreams/adapters and util to require() fix(crypto): normalize P-521 SPKI exports May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebCrypto P-521 SPKI export incompatible with Node.js for compressed EC keys

3 participants