fix(ext/node): support shouldUpgradeCallback in http server#34092
Open
bartlomieju wants to merge 2 commits into
Open
fix(ext/node): support shouldUpgradeCallback in http server#34092bartlomieju wants to merge 2 commits into
bartlomieju wants to merge 2 commits into
Conversation
bartlomieju
changed the title
Member
Author
|
@lunadogbot review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Node-compatible
shouldUpgradeCallbackhandling tonode:httpservers.The server now validates a user-provided callback, installs Node's default callback that upgrades only when an
upgradelistener exists, and consults the callback before committing requests to the upgrade path.Also enables the passing HTTP upgrade compat tests in
tests/node_compat/config.jsonc.Tests:
./x test-compat test-http-upgrade-server-callback.js./x test-compat test-http-upgrade-server.js