fix(ext/node): preserve raw socket connect when wrapping TLS#34093
Open
bartlomieju wants to merge 2 commits into
Open
fix(ext/node): preserve raw socket connect when wrapping TLS#34093bartlomieju wants to merge 2 commits into
bartlomieju wants to merge 2 commits into
Conversation
bartlomieju
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrapping a still-connecting
net.Socketwithtls.connect({ socket }).The TLS wrapper now leaves the raw socket as the TCP handle owner until its pending
connectevent has fired, then transfers ownership to the TLS socket if it was not destroyed by user code. This lets rawnet.connect(..., cb)callbacks run before TLS takes over, matching Node behavior.Also aligns custom DNS lookup options with Node by not passing
port, and ignorestest-tls-connect-keepalive-nodelay.jsbecause it requires Node's unimplementedinternal/netmodule.Tests run before final rebase:
./x build./x test-compat test-tls-connect-given-socket.js./x test-compat test-tls-connect-hints-option.js./x test-compat test-tls-connect-keepalive-nodelay.js