This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: correctly trace cppgc proto objects#1113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug specifically was this code:
ptr.ptr.trace(visitor);. It is not correct to directly callfoo.trace(visitor), since you are skipping the visitor's marking logic when you do that. You have to dovisitor.trace(&foo).In order to fix this, the impl of
ErasedPtrwas switched to useMember<T>, which is in fact the correct type to use for strong references to other cppgc objects.Fixes: #1112