fix(no_implicit_declare_namespace_export): skip declare global blocks#1484
Open
SAY-5 wants to merge 1 commit into
Open
fix(no_implicit_declare_namespace_export): skip declare global blocks#1484SAY-5 wants to merge 1 commit into
declare global blocks#1484SAY-5 wants to merge 1 commit into
Conversation
Per denoland/deno#33268, the rule fires on a top-level `declare global { ... }` block and tells users to add `export {}` to suppress it. But TypeScript explicitly rejects `export {}` inside `declare global` ("Exports and export assignments are not permitted in module augmentations"), so the suggested fix doesn't compile. Bail out of the rule when the module declaration's `global` flag is set so the hint is no longer surfaced for these blocks. Add valid-case tests covering `declare global { const ... }` and `declare global { interface Window ... }`. Closes denoland/deno#33268
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per denoland/deno#33268, the
no-implicit-declare-namespace-exportrule fires on a top-leveldeclare global { ... }block and tells users to addexport {}to suppress it. TypeScript explicitly rejectsexport {}insidedeclare global("Exports and export assignments are not permitted in module augmentations"), so the suggested fix doesn't compile.Bail out of the rule when the module declaration's
globalflag is set so the hint is no longer surfaced for these blocks. Add valid-case tests coveringdeclare global { const ... }anddeclare global { interface Window ... }.Closes denoland/deno#33268