fix: deserialize package reqs as normalized#49
Merged
dsherret merged 10 commits intoNov 15, 2025
Conversation
dsherret
changed the title
dsherret
changed the title
dsherret
commented
Nov 15, 2025
Contributor
Author
There was a problem hiding this comment.
This file is extracting out functions from npm.rs
dsherret
commented
Nov 15, 2025
| @@ -0,0 +1,159 @@ | |||
| // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. | |||
Contributor
Author
There was a problem hiding this comment.
I'll fix the out of date copyright in a different pr.
dsherret
commented
Nov 15, 2025
| pub use self::range::VersionRangeSet; | ||
| pub use self::range::XRange; | ||
| pub use self::range_set_or_tag::PackageTag; | ||
| pub use self::range_set_or_tag::RangeSetOrTag; |
Contributor
Author
There was a problem hiding this comment.
Extracted from here, so exporting them now.
lucacasonato
approved these changes
Nov 15, 2025
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Nov 15, 2025
There was a bug that was causing npm resolution to occur due to: * denoland/deno_semver#49 Also includes: * denoland/deno_semver#45
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Nov 17, 2025
There was a bug that was causing npm resolution to occur due to: * denoland/deno_semver#49 Also includes: * denoland/deno_semver#45
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Jan 22, 2026
There was a bug that was causing npm resolution to occur due to: * denoland/deno_semver#49 Also includes: * denoland/deno_semver#45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were normalizing package reqs and then deserializing them "loosely". This mean that tags like
v1.2would accidentally get parsed as a version range instead of a tag as it should be leading to bad comparisons between the lockfile and config files.