[Reveal latte] Better error handling (#31)

deprecated-packages · Jul 13, 2022 · ba982e6 · ba982e6
1 parent f6342d4
commit ba982e6
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/packages/reveal-latte/src/Rules/LatteCompleteCheckRule.php b/packages/reveal-latte/src/Rules/LatteCompleteCheckRule.php
@@ -99,8 +99,13 @@ public function processNode(Node $node, Scope $scope): array
 
         $uniqueErrorsByHash = [];
         foreach ($errors as $error) {
-            /** @var RuleError&FileRuleError&LineRuleError $error */
-            $errorHash = $error->getMessage() . $error->getFile() . $error->getLine();
+            $errorHash = $error->getMessage();
+            if ($error instanceof FileRuleError) {
+                $errorHash .= $error->getFile();
+            }
+            if ($error instanceof LineRuleError) {
+                $errorHash .= $error->getLine();
+            }
             $uniqueErrorsByHash[$errorHash] = $error;
         }
 
@@ -169,9 +174,8 @@ private function processTemplateFilePath(
                 $scope,
                 $componentNamesAndTypes
             );
-        } catch (Throwable) {
-            // missing include/layout template or something else went wrong → we cannot analyse template here
-            $errorMessage = sprintf('Template file "%s" does not exist', $templateFilePath);
+        } catch (Throwable $throwable) {
+            $errorMessage = $throwable->getMessage();
             $ruleError = RuleErrorBuilder::message($errorMessage)->build();
             return [$ruleError];
         }