Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for more complex array annotations #344

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Conversation

dereuromark
Copy link
Owner

Refs #343

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11fd9be) 82.99% compared to head (a0bf94b) 83.07%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #344      +/-   ##
============================================
+ Coverage     82.99%   83.07%   +0.07%     
- Complexity     1783     1785       +2     
============================================
  Files           114      114              
  Lines          4876     4879       +3     
============================================
+ Hits           4047     4053       +6     
+ Misses          829      826       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereuromark dereuromark changed the title Test that all different array annotations work. Allow support for more complex array annotations Feb 14, 2024
@dereuromark dereuromark merged commit 5d7912b into master Feb 14, 2024
16 checks passed
@dereuromark dereuromark deleted the array-shaped branch February 14, 2024 13:42
@Harfusha
Copy link
Contributor

It works except for multiline type (multiline type works for vscode and phpstan)

image

(When i remove the generated annotation)
image

@Harfusha
Copy link
Contributor

And will you backport it for Cakephp 4? I had to change vendor file for the test :D

@dereuromark
Copy link
Owner Author

Feel free to PR multiline support

also feel free to backport this to 4.x

Currently I dont have the time here.

@Harfusha
Copy link
Contributor

I will try to do it later on (This is still magic for me, but i will figure it out)

@dereuromark
Copy link
Owner Author

Cool
You now know at least which files and what lines are to be touched/fixed.

Harfusha pushed a commit to Harfusha/cakephp-ide-helper that referenced this pull request Mar 5, 2024
Harfusha pushed a commit to Harfusha/cakephp-ide-helper that referenced this pull request Mar 5, 2024
dereuromark added a commit that referenced this pull request Mar 5, 2024
Backported support for more complex array annotations (#344) and for multiline annotation (#345) to Cake4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants