-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow support for more complex array annotations #344
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
============================================
+ Coverage 82.99% 83.07% +0.07%
- Complexity 1783 1785 +2
============================================
Files 114 114
Lines 4876 4879 +3
============================================
+ Hits 4047 4053 +6
+ Misses 829 826 -3 ☔ View full report in Codecov by Sentry. |
And will you backport it for Cakephp 4? I had to change vendor file for the test :D |
Feel free to PR multiline support also feel free to backport this to 4.x Currently I dont have the time here. |
I will try to do it later on (This is still magic for me, but i will figure it out) |
Cool |
… and for multiline annotation (dereuromark#345) to Cake4.
Refs #343