Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cookies to fix silent login #249

Conversation

rupato-deriv
Copy link
Contributor

This pull request includes changes to improve the handling of user login IDs by utilizing cookies in addition to local storage. The most important changes involve importing the js-cookie library and updating the logic to read and log user login IDs from cookies.

Enhancements to user login ID handling:

  • src/app/App.tsx: Imported js-cookie and updated the useEffect hook to read active_loginid from cookies, falling back to local storage if necessary. Added a console log for debugging purposes. [1] [2]
  • src/pages/callback/callback-page.tsx: Imported js-cookie and updated the logic to read active_loginid from cookies if tokens are not set, with a console log for debugging purposes. [1] [2]

Copy link

Name Result
Build status Failed ❌
Action URL Visit Action

@rupato-deriv rupato-deriv merged commit 10b8d70 into deriv-com:master Feb 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant