fix: oidc #310
Merged
fix: oidc #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/components/layout/index.tsx,src/external/bot-skeleton/services/api/api-base.ts, andsrc/pages/callback/callback-page.tsxfiles. The changes mainly focus on improving the handling of account and currency data, as well as some minor refactoring.Improvements to account and currency handling:
src/components/layout/index.tsx: Modified thevalidateApiAccountsfunction to handle account lists more effectively and ensure the correct currency is set in session storage. [1] [2]src/external/bot-skeleton/services/api/api-base.ts: Updated theAPIBaseclass to remove filtering of disabled accounts when setting the account list.Refactoring and code simplification:
src/components/layout/index.tsx: Removed a console log statement related toquery_param_currencyfor cleaner code.src/pages/callback/callback-page.tsx: Refactored theCallbackPagecomponent to simplify the handling of thestateparameter and improve currency selection logic. [1] [2]