farabi/fix--position-page-and-account-switcher

[farabi-deriv]

This pull request includes several updates to improve the responsiveness and usability of the AccountSwitcher and PositionsPage components. The main changes involve replacing the use of device detection with orientation detection and enhancing the layout and styling of the PositionsPage.

Updates to AccountSwitcher component:

• Replaced useDeviceDetection with useOrientationStore to determine if the device is in landscape mode instead of checking if it's a desktop. (src/components/AccountSwitcher/AccountSwitcher.tsx) [1] [2] [3]

Updates to account-popover component:

• Replaced useDeviceDetection with useOrientationStore for consistent orientation-based styling and behavior. (src/components/ui/account-popover.tsx) [1] [2] [3]

Enhancements to PositionsPage layout:

• Improved the layout and styling of the PositionsPage to make it more flexible and visually appealing. Changes include making the container flex-based, making tabs sticky, and updating the appearance of the positions list. (src/screens/PositionsPage/PositionsPage.tsx)

Summary by Sourcery

This pull request enhances the responsiveness and usability of the AccountSwitcher and PositionsPage components by using orientation detection instead of device detection and improving the layout of the PositionsPage.

Enhancements:

• Improved the layout and styling of the PositionsPage component, including making the container flex-based and the tabs sticky.
• Replaced device detection logic with orientation detection in the AccountSwitcher and account-popover components to improve responsiveness on different devices.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request enhances the responsiveness and usability of the AccountSwitcher and PositionsPage components by replacing device detection with orientation detection and improving the layout and styling of the PositionsPage.

Updated class diagram for AccountSwitcher

classDiagram
  class AccountSwitcher {
    +balance: number
    +accountType: string
    +selectedAccount: string
    +isLandscape: boolean
    +isOpen: boolean
    +setIsOpen(isOpen: boolean): void
  }

  note for AccountSwitcher "Replaced useDeviceDetection with useOrientationStore to determine if the device is in landscape mode."

Loading

Updated class diagram for AccountPopoverContent

classDiagram
  class AccountPopoverContent {
    +isLandscape: boolean
  }

  note for AccountPopoverContent "Replaced useDeviceDetection with useOrientationStore for consistent orientation-based styling and behavior."

Loading

Updated class diagram for PositionsPage

classDiagram
  class PositionsPage {
    +activeTab: string
    +positions: Position[]
    +swipedCard: string
    +setActiveTab(tab: string): void
  }

  class Position {
    +isOpen: boolean
  }

  PositionsPage -- Position : has many

  note for PositionsPage "Improved the layout and styling of the PositionsPage to make it more flexible and visually appealing."

Loading

File-Level Changes

Change	Details	Files
Replaced device detection with orientation detection in AccountSwitcher and account-popover components.	Replaced useDeviceDetection with useOrientationStore. Updated component styling and behavior based on orientation (landscape/portrait) instead of device type (desktop/mobile).	src/components/AccountSwitcher/AccountSwitcher.tsx src/components/ui/account-popover.tsx
Improved layout and styling of the PositionsPage component.	Made the container flex-based for better responsiveness. Made tabs sticky for improved usability. Updated the appearance of the positions list with improved spacing and styling.	src/screens/PositionsPage/PositionsPage.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[sourcery-ai]

Hey @farabi-deriv - I've reviewed your changes - here's some feedback:

Overall Comments:

• The changes from useDeviceDetection to useOrientationStore look good, but ensure that the orientation store is properly handling different screen sizes and resolutions.
• The styling changes in PositionsPage look good, but consider using a more descriptive class name than bg-gray-100.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}