Farabi/fix switching in account switcher #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request enhances the account switching functionality by adding support for demo accounts, updating UI elements to distinguish between demo and real accounts, and modifying the account data configuration. The changes include modifications to the AccountInfo and AccountSwitcher components, the useAccount hook, and the accountConfig file. Sequence diagram for resetting balance in a demo accountsequenceDiagram
participant User
participant AccountInfo Component
participant useClientStore Hook
User->>AccountInfo Component: Clicks "Reset balance" button
activate AccountInfo Component
AccountInfo Component->>useClientStore Hook: Calls setBalance("10000", "USD")
activate useClientStore Hook
useClientStore Hook-->>AccountInfo Component: Updates balance in store
deactivate useClientStore Hook
AccountInfo Component-->>User: Updates UI with reset balance
deactivate AccountInfo Component
Updated class diagram for AccountInfoclassDiagram
class AccountInfo {
+id: string
+displayName: string
+currency: string
+accountNumber: string
+isDemo?: boolean
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Manifest Filespackage-lock.json
package.json
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @farabi-deriv - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more descriptive name than
isDemofor the account type to improve readability. - The logic for determining the account type in
AccountSwitcher.tsxcould be simplified by directly checkingselectedAccount?.isDemo.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Deploying champion-trader with
|
| Latest commit: |
b21f73e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02091235.champion-trader.pages.dev |
| Branch Preview URL: | https://farabi-fix--switching-in-acc.champion-trader.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the account switching functionality and improve the user interface for demo and real accounts. The most important changes include adding support for demo accounts, updating UI elements to distinguish between demo and real accounts, and modifying the account data configuration.
Enhancements to account switching functionality:
src/components/AccountSwitcher/AccountInfo.tsx: AddedsetBalancetouseClientStoreand updated theCurrencyIconcomponent to accept anisVirtualprop. Added a "Reset balance" button for demo accounts to reset the balance to 10000 USD. [1] [2] [3]src/components/AccountSwitcher/AccountSwitcher.tsx: RemovedaccountTypeand updated references to useselectedAccountto determine if the account is a demo or real account. [1] [2]Updates to account data configuration:
src/config/accountConfig.ts: AddedisDemoproperty to theAccountInfointerface and included a demo account in theaccountDataarray.Modifications to account hooks:
src/hooks/useAccount.ts: Removed unnecessary logic when switching account types and updated thegetAvailableAccountsfunction to filter accounts based on theisDemoproperty. [1] [2]Summary by Sourcery
Improves the account switching functionality by adding support for demo accounts and enhancing the user interface to differentiate between demo and real accounts. It also introduces a 'Reset balance' button for demo accounts.
New Features:
Enhancements:
isDemoproperty.