Henry/grwt 4935/contract details chart

[henry-deriv]

Summary by Sourcery

This pull request introduces a ContractDetailsChart component and integrates it into the DesktopContractDetailsPage. It also updates the TradeChart component to display tick data.

New Features:

• Introduces a new ContractDetailsChart component to display contract-specific chart data.

Enhancements:

• Updates the TradeChart component to display tick data instead of candle data.
• Improves the responsiveness of the ContractDetailsChart component by adjusting its height based on the device type.

[cloudflare-workers-and-pages]

Deploying champion-trader with    Cloudflare Pages

Latest commit:	19a889b
Status:	✅  Deploy successful!
Preview URL:	https://af62efbb.champion-trader.pages.dev
Branch Preview URL:	https://henry-grwt-4935-contract-det.champion-trader.pages.dev

View logs

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new ContractDetailsChart component for displaying contract details on the desktop contract details page. It also updates the existing TradeChart component to use tick data and includes device-specific styling for the new chart. Mocking was added for testing purposes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Introduces a new ContractDetailsChart component to display contract-specific chart data.	Created a new component ContractDetailsChart. Implemented the chart using SmartChart component. Fetched and transformed historical tick data for the chart. Configured streaming data for real-time updates.	src/components/ContractDetailsChart/ContractDetailsChart.tsx src/screens/ContractDetailsPage/DesktopContractDetailsPage.tsx src/screens/ContractDetailsPage/__tests__/DesktopContractDetailsPage.test.tsx
Updates the TradeChart component to use tick data instead of candle data.	Switched from generateHistoricalCandles to generateHistoricalTicks. Updated transformCandleData to transformTickData. Modified the streaming data configuration to use 'tick' type. Set the chart type to 'line'. Set granularity to 0.	src/components/Chart/Chart.tsx
Adds a conditional height to the ContractDetailsChart based on device type.	Added useDeviceDetection hook to detect device type. Set height to 'h-full' for desktop and 'h-[400px]' for other devices.	src/components/ContractDetailsChart/ContractDetailsChart.tsx
Mocks the ContractDetailsChart component in the desktop contract details page tests.	Added a mock implementation for ContractDetailsChart in the test file.	src/screens/ContractDetailsPage/__tests__/DesktopContractDetailsPage.test.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[sourcery-ai]

Hey @henry-deriv - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider creating a shared configuration object for the chart, instead of having similar logic in two components.
• The conditional height styling in ContractDetailsChart could be moved to the useDeviceDetection hook.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}