Farabi/fix contract details page desktop

[farabi-deriv]

This pull request focuses on updating the device detection logic to use orientation detection instead. The most important changes include replacing useDeviceDetection with useOrientationStore across various components and adjusting the layout and styles accordingly.

Changes to device detection logic:

• src/components/ContractDetailsChart/ContractDetailsChart.tsx: Replaced useDeviceDetection with useOrientationStore and updated the layout to use isLandscape instead of isDesktop. [1] [2]
• src/layouts/MainLayout/MainLayout.tsx: Removed isDesktop from useDeviceDetection and replaced it with isLandscape from useOrientationStore for layout adjustments. [1] [2]
• src/screens/ContractDetailsPage/ContractDetailsPage.tsx: Replaced useDeviceDetection with useOrientationStore and updated the conditional rendering logic to use isLandscape instead of isMobile. [1] [2]

Changes to layout and styles:

• src/screens/ContractDetailsPage/DesktopContractDetailsPage.tsx: Adjusted styles and layout for the desktop contract details page, including removing the full height class and modifying padding and margins. [1] [2]
• src/screens/ContractDetailsPage/__tests__/DesktopContractDetailsPage.test.tsx: Updated tests to reflect the new layout and style changes for the desktop contract details page.

Summary by Sourcery

Enhancements:

• Update device detection logic to use orientation detection instead of device detection.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the device detection logic to use orientation detection instead of device type detection. It replaces useDeviceDetection with useOrientationStore and adjusts the layout and styles of the contract details page for desktop screens. The tests have also been updated to reflect these changes.

Sequence diagram for rendering ContractDetailsPage

sequenceDiagram
  participant CDP as ContractDetailsPage
  participant OS as useOrientationStore
  participant DCDP as DesktopContractDetailsPage
  participant MC as MobileContractDetailsPage

  CDP->OS: isLandscape
  alt isLandscape is false
    CDP->MC: Render MobileContractDetailsPage
  else isLandscape is true
    CDP->DCDP: Render DesktopContractDetailsPage
  end

Loading

Updated class diagram for device detection logic

classDiagram
  class useDeviceDetection {
    - isMobile: boolean
    - isDesktop: boolean
  }
  note for useDeviceDetection "Deprecated"
  class useOrientationStore {
    + isLandscape: boolean
    + setIsLandscape(isLandscape: boolean): void
  }

  useOrientationStore --|> orientationChangeEvent : listens to

Loading

Updated class diagram for DesktopContractDetailsPage

classDiagram
  class DesktopContractDetailsPage {
    -className: string
  }
  note for DesktopContractDetailsPage "Adjusted styles and layout"

Loading

File-Level Changes

Change	Details	Files
Replaced useDeviceDetection with useOrientationStore to determine layout based on screen orientation.	Replaced useDeviceDetection with useOrientationStore. Updated conditional logic to use isLandscape instead of isDesktop or isMobile.	src/components/ContractDetailsChart/ContractDetailsChart.tsx src/layouts/MainLayout/MainLayout.tsx src/screens/ContractDetailsPage/ContractDetailsPage.tsx
Adjusted styles and layout of the desktop contract details page.	Removed the full height class from the main container. Modified padding and margins for improved layout. Updated the position of the close button.	src/screens/ContractDetailsPage/DesktopContractDetailsPage.tsx
Updated tests to reflect the layout and style changes.	Updated assertions to match the new CSS classes and layout structure.	src/screens/ContractDetailsPage/__tests__/DesktopContractDetailsPage.test.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[sourcery-ai]

Hey @farabi-deriv - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider renaming useOrientationStore to useOrientation for brevity and clarity.
• Ensure that the useOrientationStore provides a default value or handles initial undefined states to prevent unexpected behavior.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[cloudflare-workers-and-pages]

Deploying champion-trader with    Cloudflare Pages

Latest commit:	918677a
Status:	✅  Deploy successful!
Preview URL:	https://2394cfa6.champion-trader.pages.dev
Branch Preview URL:	https://farabi-fix-contract-details.champion-trader.pages.dev

View logs