Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing border from contract Details desktop, add component readme files and renaming left-sidebar #57

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented Feb 24, 2025

Summary by Sourcery

Enhancements:

  • Removed the right border from the left panel in the contract details page to improve the UI.

Copy link

sourcery-ai bot commented Feb 24, 2025

Reviewer's Guide by Sourcery

This pull request removes the right border from the left panel in the desktop contract details page. The test was updated to reflect this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the right border from the left panel in the desktop contract details page.
  • Removed border-r class from the left panel.
  • Updated the test to reflect the removal of the right border.
src/screens/ContractDetailsPage/DesktopContractDetailsPage.tsx
src/screens/ContractDetailsPage/__tests__/DesktopContractDetailsPage.test.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

cloudflare-workers-and-pages bot commented Feb 24, 2025

Deploying champion-trader with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24f91cc
Status: ✅  Deploy successful!
Preview URL: https://86e415a2.champion-trader.pages.dev
Branch Preview URL: https://f-positon-fix.champion-trader.pages.dev

View logs

Copy link

github-actions bot commented Feb 24, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ahmadtaimoor-deriv - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider whether the border should be removed entirely or moved to a different element.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ahmadtaimoor-deriv ahmadtaimoor-deriv changed the title F positon fix Removing border form the contract Details desktop and adding readme files to components. Feb 25, 2025
@ahmadtaimoor-deriv
Copy link
Contributor Author

sourcery-ai

@ahmadtaimoor-deriv
Copy link
Contributor Author

@sourcery-ai

@ahmadtaimoor-deriv ahmadtaimoor-deriv changed the title Removing border form the contract Details desktop and adding readme files to components. Removing border from contract Details desktop, add component readme files and renaming left-sidebar Feb 25, 2025
@ahmadtaimoor-deriv
Copy link
Contributor Author

@sourcery-ai

@ahmadtaimoor-deriv ahmadtaimoor-deriv merged commit 50f6c91 into master Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants