-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing border from contract Details desktop, add component readme files and renaming left-sidebar #57
Conversation
Reviewer's Guide by SourceryThis pull request removes the right border from the left panel in the desktop contract details page. The test was updated to reflect this change. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying champion-trader with
|
Latest commit: |
24f91cc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://86e415a2.champion-trader.pages.dev |
Branch Preview URL: | https://f-positon-fix.champion-trader.pages.dev |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ahmadtaimoor-deriv - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider whether the border should be removed entirely or moved to a different element.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sourcery-ai |
Summary by Sourcery
Enhancements: