Farabi/fix landscape view issues

[farabi-deriv]

This pull request includes several changes across multiple files, primarily focusing on replacing the useDeviceDetection hook with the useOrientationStore hook to determine the device's orientation. Additionally, some minor adjustments to layout and behavior based on orientation have been made.

Replacing useDeviceDetection with useOrientationStore:

• src/components/BottomSheet/BottomSheet.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3]
• src/components/Duration/DurationController.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3] [4] [5] [6] [7]
• src/components/Duration/DurationField.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3] [4]
• src/components/Stake/StakeController.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3] [4] [5] [6] [7]
• src/components/Stake/StakeField.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3]
• src/components/TradeFields/TradeParamField.tsx: Replaced useDeviceDetection with useOrientationStore and updated references from isDesktop to isLandscape. [1] [2] [3]

Layout and behavior adjustments:

• src/components/HowToTrade/HowToTrade.tsx: Adjusted the bottom sheet height from 90% to 80% for mobile devices. [1] [2]
• src/components/SideNav/SideNav.tsx: Changed the z-index value from 100 to 60 for the side navigation bar.

Test updates:

• src/components/BottomSheet/__tests__/BottomSheet.test.tsx: Removed the test case for closing the bottom sheet on desktop since the detection logic has been updated.

Summary by Sourcery

This pull request focuses on improving the application's adaptability to different device orientations. It replaces the useDeviceDetection hook with useOrientationStore to accurately detect landscape mode, and adjusts UI components accordingly. Additionally, it includes minor layout adjustments and a test update to reflect the changes.

Enhancements:

• Replaced the useDeviceDetection hook with the useOrientationStore hook to determine device orientation, improving accuracy and responsiveness to orientation changes.
• Adjusted the bottom sheet height for the 'How To Trade' component on mobile devices from 90% to 80% for better usability.
• Modified the z-index of the side navigation bar to ensure proper layering and visibility.

Tests:

• Removed a test case related to closing the bottom sheet on desktop, as the underlying detection logic has been updated.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request primarily replaces the useDeviceDetection hook with useOrientationStore to improve handling of device orientation. It also includes minor layout adjustments and test updates related to this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Replaced the useDeviceDetection hook with the useOrientationStore hook to determine device orientation and updated related references.	Replaced useDeviceDetection with useOrientationStore. Updated references from isDesktop to isLandscape.	src/components/BottomSheet/BottomSheet.tsx src/components/Duration/DurationController.tsx src/components/Duration/DurationField.tsx src/components/Stake/StakeController.tsx src/components/Stake/StakeField.tsx src/components/TradeFields/TradeParamField.tsx
Adjusted the bottom sheet height for mobile devices.	Changed bottom sheet height from 90% to 80% for mobile devices.	src/components/HowToTrade/HowToTrade.tsx src/components/HowToTrade/__tests__/HowToTrade.test.tsx src/screens/TradePage/TradePage.tsx
Updated the z-index value for the side navigation bar.	Changed the z-index value from 100 to 60.	src/components/SideNav/SideNav.tsx
Removed a test case related to the old device detection logic.	Removed the test case for closing the bottom sheet on desktop.	src/components/BottomSheet/__tests__/BottomSheet.test.tsx
Added margin to the contract summary component.	Added margin to the bottom of the component.	src/screens/ContractDetailsPage/components/ContractSummary.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[cloudflare-workers-and-pages]

Deploying champion-trader with    Cloudflare Pages

Latest commit:	6045cb4
Status:	✅  Deploy successful!
Preview URL:	https://c9b9bfe2.champion-trader.pages.dev
Branch Preview URL:	https://farabi-fix-landscape-view-is.champion-trader.pages.dev

View logs

[sourcery-ai]

Hey @farabi-deriv - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a consistent naming convention (e.g., isLandscape vs isDesktop) throughout the codebase for device orientation checks.
• Verify that the removal of the desktop bottom sheet close test doesn't introduce regressions on other platforms.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}