Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Sergei / TRAH - 2691 / The header is truncated in a specific width #13095

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Jan 23, 2024

Changes:

  • change is_desktop to !is_mobile, because is_desktop is true when the screen size is more than 1024 px

Card:

https://app.clickup.com/t/20696747/TRAH-2691

Screenshots:

image

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 1, 2024 9:05am

Copy link
Contributor

github-actions bot commented Jan 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13095](https://github.com/binary-com/deriv-app/pull/13095)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2691traders-919b72.binary.sx?qa_server=red.derivws.com&app_id=38763
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2691traders-919b72.binary.sx
- **App ID**: `38763`

Copy link
Contributor

github-actions bot commented Jan 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-2691traders-919b72.binary.sx/

mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Jan 24, 2024
shahzaib-deriv
shahzaib-deriv previously approved these changes Jan 24, 2024
@coveralls
Copy link

coveralls commented Jan 24, 2024

Coverage Status

coverage: 34.627% (-0.006%) from 34.633%
when pulling fb2a0e3 on sergei-deriv:sergei/trah-2691/traders-hub-header-1024-issue
into 8a43b24 on binary-com:master.

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit 0cb6e53 into deriv-com:master Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants