-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFDS] shontzu/TRAH-4372/cfds-unavailable-tag-content-update #17968
Merged
jim-deriv
merged 9 commits into
deriv-com:master
from
shontzu-deriv:shontzu/TRAH-4372/cfds-unavailable-tag-content-update
Feb 26, 2025
Merged
[CFDS] shontzu/TRAH-4372/cfds-unavailable-tag-content-update #17968
jim-deriv
merged 9 commits into
deriv-com:master
from
shontzu-deriv:shontzu/TRAH-4372/cfds-unavailable-tag-content-update
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-4372cfds-u-060fe2.binary.sx/ |
…le-tag-content-update
⏳ Generating Lighthouse report... |
…of github.com:shontzu-deriv/deriv-app into shontzu/TRAH-4372/cfds-unavailable-tag-content-update
hasan-deriv
approved these changes
Feb 13, 2025
…le-tag-content-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is to update the content for CFDs "unavailable" tag to make it more meaningful for users.
Acceptance Criteria:
Change 1:
Tag content update to: "Temporarily Unavailable"
Change 2:
When user clicks on tag, popup content needs to be updated.
Title: Account temporarily unavailable
Body: Check back in a few minutes by refreshing the page.
CTA: OK