Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] shontzu/TRAH-5356/fe-implementation-api-group-cleanup #17999

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Jan 17, 2025

Changes:

EU no longer limited to financial products since trading team insisted DIEL financial should have synthetic instrument too

Before:
in EU, MT5 is shown as MT5 CFDs with yellow variant icon

After:
in EU, MT5 CFDsshould just show MT5 Standard with the regular blue icon

Note to dev:
BE deployed in qa137
use es mf account for EU tradershub
use cz mfw for EU wallets

Screenshots:

Tradershub fix:

Screen.Recording.2025-01-17.at.4.48.15.PM.mov

Wallets fix:

d06055d9-7229-4a56-a473-504d7aab728d.mov

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 19, 2025 6:30am

@shontzu-deriv shontzu-deriv changed the title Shontzu/trah 5356/fe implementation api group cleanup [TRAH] shontzu/TRAH-5356/fe-implementation-api-group-cleanup Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17999](https://github.com/deriv-com/deriv-app/pull/17999)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-5356fe-imp-e9c66b.binary.sx?qa_server=red.derivws.com&app_id=32761
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-5356fe-imp-e9c66b.binary.sx
- **App ID**: `32761`

Copy link
Contributor

github-actions bot commented Jan 17, 2025

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-5356fe-imp-e9c66b.binary.sx/

heorhi-deriv
heorhi-deriv previously approved these changes Jan 17, 2025
jim-deriv
jim-deriv previously approved these changes Jan 20, 2025
@shontzu-deriv shontzu-deriv force-pushed the shontzu/TRAH-5356/fe-implementation-api-group-cleanup branch from f7b4bda to 190bde5 Compare February 18, 2025 09:39
@shontzu-deriv shontzu-deriv force-pushed the shontzu/TRAH-5356/fe-implementation-api-group-cleanup branch from 190bde5 to f72f2bb Compare February 18, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants