Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suisin/chore: fix blank screen issue #18107

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Suisin/chore: fix blank screen issue #18107

merged 3 commits into from
Mar 6, 2025

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Dtrader page is not showing issue

Screenshots:

Please provide some screenshots of the change.

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 6, 2025 9:05am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18107](https://github.com/deriv-com/deriv-app/pull/18107)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-webrel3747dtrader-5bb2f8.binary.sx?qa_server=red.derivws.com&app_id=31586
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-webrel3747dtrader-5bb2f8.binary.sx
- **App ID**: `31586`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

⏳ Generating Lighthouse report...

adrienne-deriv
adrienne-deriv approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amam-deriv
amam-deriv reviewed Mar 6, 2025
View reviewed changes
packages/core/src/App/Containers/Redirect/redirect.jsx

const Redirect = observer(() => {
const history = useHistory();
const { client, ui } = useStore();
const { isOAuth2Enabled } = useOauth2({});
const [queryCurrency, setQueryCurrency] = useState('USD');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] is this default USD intentional?

@amam-deriv amam-deriv merged commit 39c1841 into deriv-com:master Mar 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@amam-deriv amam-deriv amam-deriv approved these changes

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suisin-deriv @adrienne-deriv @amam-deriv