Suisin/chore: fix redirection to dtrader everytime landing on home page after coming from smart trader #18120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
⏳ Generating Lighthouse report... |
amam-deriv
reviewed
Mar 7, 2025
| @@ -95,6 +95,14 @@ const Trade = observer(() => { | |||
| return null; | |||
| }, [try_synthetic_indices, try_open_markets, category, subcategory]); | |||
|
|
|||
| React.useEffect(() => { | |||
| const has_session_storage = !!sessionStorage.getItem('tradershub_redirect_to'); | |||
There was a problem hiding this comment.
[m] by right this should be placed on the logic when we are redirecting
There was a problem hiding this comment.
We can't clear the sessionStorage when routing happen is because OIDC call back page depends on the sessionStorage route, if we remove it before we redirect them to Dtrader page, when OIDC kicks in, it will bring user back to the tradershub home page.
amam-deriv
previously approved these changes
Mar 7, 2025
amam-deriv
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Clear session storage once we land on Dtrader page so that OIDC won't take the session storage value
Screenshots:
Please provide some screenshots of the change.