akhil/1340/fetching_the_list_of_wallets_available_to_create #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add dart new features to the code generator
- upgrade deriv api to flutter version 3
- upgrade to flutter 3.10.0
- migrate flutter version to 3.10.0
- update dependencies
- upgrade kotlin version
- improve test coverage
- fix connectivity issue
- remove http client
- update package for wallet
- updated p2p order list api request.
…ction Osama/Change redirection url to auth endpoint
…_change_support_deriv_api waqas/add_language_support_to_deriv_api
akhil-deriv
commented
Dec 11, 2023
lib/basic_api/generated/methods/available_accounts_receive_methods.json
Outdated
Show resolved
Hide resolved
akhil-deriv
commented
Dec 13, 2023
akhil-deriv
commented
Dec 13, 2023
ramin-deriv
reviewed
Dec 20, 2023
| @@ -222,8 +224,6 @@ Response getGeneratedResponse(Map<String, dynamic> responseMap) { | |||
| return GetAccountStatusReceive.fromJson(responseMap); | |||
| case 'get_account_types': | |||
| return GetAccountTypesReceive.fromJson(responseMap); | |||
| case 'get_available_accounts_to_transfer': | |||
There was a problem hiding this comment.
I think this call will be used for native cashier. this is removed by the auto generator?
There was a problem hiding this comment.
Yes, this was removed as part of the auto generation. Do you think I should keep it in?
There was a problem hiding this comment.
I see. then it's fine. so perhaps they are going to make any change on that call. I think it's worth checking with BE on that.
…1340/fetching_the_list_of_wallets_available_to_create
ramin-deriv
approved these changes
Dec 21, 2023
|
@akhil-deriv We should switch to |
waqas-younas-deriv
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup link: https://app.clickup.com/t/20696747/DERG-1344
This PR contains the following changes:
This PR implements the API call that fetches the available wallets to create.
✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
@ramin-deriv @waqas-younas-deriv\
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)