nuzhy/CSIT-1704/intercom integration #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nuzhy-Deriv
commented
Nov 27, 2024
Nuzhy-Deriv
commented
- integrated Intercom
- updated useFreshChat hook to load freshchat script only if the flag is true
- handled clear conversation on logout for freshchat, intercom in both desktop, mobile
Nuzhy-Deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
nada-deriv
reviewed
Nov 27, 2024
| getFlags: async () => { | ||
| const [isFreshChat, isIntercom] = await Promise.all([Chat.isFreshChat(), Chat.isIntercom()]); | ||
| return { isFreshChat, isIntercom }; | ||
| }, |
There was a problem hiding this comment.
do we need any error handling here and for the above .then ?
There was a problem hiding this comment.
added try catch blocks in both places
|
Preview Link: https://nuzhy-intercom-integ.p2p-standalone.pages.dev
|
ameerul-deriv
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.