Ameerul / FEWP-366 Migrate P2P standalone to OIDC #420
+207
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ameerul-deriv
commented
Dec 12, 2024
•
ameerul-deriv
commented
- Implemented OIDC in standalone
ameerul-deriv
requested review from
yashim-deriv and
farrah-deriv
as code owners
thisyahlen-deriv
approved these changes
Dec 12, 2024
| } | ||
| } | ||
| }, [isEndpointPage, error?.code, isAuthorized, isAuthorizing, oAuthLogout, oauthUrl]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
nit: I don't think we need to useCallback this function imo, it has way much dependencies already and its not that complex 😅
farrah-deriv
approved these changes
Dec 13, 2024
…te-p2p-standalone-to-oidc
…te-p2p-standalone-to-oidc
…ameerul-deriv/dp2p-v2 into FEWP-366-migrate-p2p-standalone-to-oidc
Adrienne / Add front channels and safari check
|
Preview Link: https://FEWP-366-migrate-p2p.p2p-standalone.pages.dev
|
Adrienne / Fix test cases with logout
Adrienne / Fix issue where network error occured in firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.