Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/opt_662_xrp_payout_currency #48

Conversation

tanvir-deriv
Copy link
Contributor

@tanvir-deriv tanvir-deriv commented Apr 16, 2024

Description

To allow user to use XRP as payout currency.

In this card, we add XRP to precision.yml .

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (f6e89e6) to head (85fb9dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           2        2           
  Lines         100      100           
  Branches       24       24           
=======================================
  Hits           96       96           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinfeng-deriv
Copy link

Where are the CHANGES log?

@tanvir-deriv
Copy link
Contributor Author

tanvir-deriv commented Apr 16, 2024

Where are the CHANGES log?

From wikijs, it seemed to me that I need to add that after code review, QA and dzil release. Should I add it before? @qinfeng-deriv

@kalaiselvan-deriv kalaiselvan-deriv merged commit 38ed2d7 into deriv-com:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants