Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meenu/[QUILL-1777] bottom tab draft #661

Merged

Conversation

meenakshi-deriv
Copy link
Contributor

@meenakshi-deriv meenakshi-deriv commented Jun 24, 2024

Changes:

This PR has the integration of quill components in bottom section of smarttrader.

Library:

  • @deriv-com/quill-ui -The tabs are replaced with SegmentedControlSingleChoice from quill-ui . Quill components are used under javascript folder to get the complete functionality as we have issue with rendering components under templates.
  • html-react-parser - To parse html elements from translated strings.

Localization:

  • For translation we are using localize and refactored localize.js to extract strings correctly from it.L .

Hooks:

  • useContractChange, triggerContractChange - for extracting data whenever contract or market is changed.

Style:

  • reset.scss - added this to avoid default style getting overridden while using quill.
  • reskin-scss - all styles for reskin will be added under this file.
Screenshot 2024-06-26 at 12 28 37 PM Screenshot 2024-06-26 at 12 28 00 PM Screenshot 2024-06-26 at 12 28 09 PM

@meenakshi-deriv meenakshi-deriv requested a review from a team as a code owner June 24, 2024 06:59
@meenakshi-deriv meenakshi-deriv changed the base branch from master to redesign June 24, 2024 06:59
Copy link

Preview Link: https://pr-661.smarttrader-preview.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@prince-deriv prince-deriv merged commit 86363ae into deriv-com:redesign Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants