-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meenu/[QUILL-1777] bottom tab draft #661
Merged
prince-deriv
merged 25 commits into
deriv-com:redesign
from
meenakshi-deriv:meenu-bottom-tab-draft
Jun 26, 2024
Merged
Meenu/[QUILL-1777] bottom tab draft #661
prince-deriv
merged 25 commits into
deriv-com:redesign
from
meenakshi-deriv:meenu-bottom-tab-draft
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft' into meenu-bottom-tab-draft
Preview Link: https://pr-661.smarttrader-preview.pages.dev
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR has the integration of quill components in bottom section of smarttrader.
Library:
@deriv-com/quill-ui
-The tabs are replaced withSegmentedControlSingleChoice
from quill-ui . Quill components are used under javascript folder to get the complete functionality as we have issue with rendering components under templates.html-react-parser
- To parse html elements from translated strings.Localization:
localize
and refactoredlocalize.js
to extract strings correctly fromit.L
.Hooks:
useContractChange
,triggerContractChange
- for extracting data whenever contract or market is changed.Style:
reset.scss
- added this to avoid default style getting overridden while using quill.reskin-scss
- all styles for reskin will be added under this file.