Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aizad/FEQ-1566/Added Accordion Component #106

Merged
merged 23 commits into from
Apr 3, 2024

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Mar 6, 2024

Created new Accordion component.
Props:

  1. allowMultiple
  2. disableAnimation
  3. isCompact
  4. sections
  5. variants
Screen.Recording.2024-03-06.at.6.26.49.PM.mov

@aizad-deriv aizad-deriv self-assigned this Mar 6, 2024
@markw-deriv
Copy link
Contributor

Should the whole title row trigger the expand/contract action?

For example, if I click here, should it expand?

Screenshot 2024-03-07 at 07 04 32

@aizad-deriv
Copy link
Contributor Author

aizad-deriv commented Mar 7, 2024

Should the whole title row trigger the expand/contract action?

For example, if I click here, should it expand?

Screenshot 2024-03-07 at 07 04 32

Based on production and the design file it shows that only when the user clicks on the Arrow Button only then it will expand:
image
Link to Figma

@markw-deriv
Copy link
Contributor

Is it used for this? It expands/collapses when I click the title.

Screenshot 2024-03-07 at 09 25 38

@aizad-deriv
Copy link
Contributor Author

Is it used for this? It expands/collapses when I click the title.

Screenshot 2024-03-07 at 09 25 38

That seems like a single Accordion however in deriv-app it's called a content-expander, which has its own special use case and functionality. To be honest you can use the accordion for that but it may lack some of the functionalities of the content-expander.

@markw-deriv
Copy link
Contributor

Is it used for this? It expands/collapses when I click the title.
Screenshot 2024-03-07 at 09 25 38

That seems like a single Accordion however in deriv-app it's called a content-expander, which has its own special use case and functionality. To be honest you can use the accordion for that but it may lack some of the functionalities of the content-expander.

Weird. But cool, just wanted to check it's got the same functionality as production, which is seems like it does then. thanks @aizad-deriv

Copy link

cloudflare-workers-and-pages bot commented Mar 8, 2024

Deploying deriv-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80f8010
Status: ✅  Deploy successful!
Preview URL: https://f42d1c74.deriv-ui.pages.dev
Branch Preview URL: https://aizad-feq-1566-add-accordion.deriv-ui.pages.dev

View logs

Copy link
Contributor

@shayan-deriv shayan-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to check if it's possible to use string over number for the activeIndex

@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8533144891

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 45.636%

Totals Coverage Status
Change from base Build 8532933824: 1.6%
Covered Lines: 144
Relevant Lines: 312

💛 - Coveralls

@shayan-deriv shayan-deriv merged commit 8f71df3 into main Apr 3, 2024
3 checks passed
@shayan-deriv shayan-deriv deleted the aizad/FEQ-1566/add-accordion branch April 3, 2024 05:33
Copy link

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants