chore: add tests for checkbox #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markw-deriv
commented
Mar 7, 2024
| <Checkbox name="test-checkbox" label="Test Checkbox" labelClassName="custom-label-class" readOnly /> | ||
| ); | ||
|
|
||
| const checkboxWrapper = screen.getByLabelText('Test Checkbox')?.parentElement?.parentElement; |
There was a problem hiding this comment.
This was quite hard to test, which hints that the implementation might not be great.
Deploying with
|
| Latest commit: |
3b14bd2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c44240bd.deriv-ui.pages.dev |
| Branch Preview URL: | https://add-tests-for-checkbox.deriv-ui.pages.dev |
shayan-deriv
reviewed
Mar 8, 2024
| test('triggers onChange event when clicked', () => { | ||
| const handleChange = jest.fn(); | ||
| render(<Checkbox name="test-checkbox" onChange={handleChange} />); | ||
| fireEvent.click(screen.getByRole('checkbox')); |
There was a problem hiding this comment.
just out of curiosity 🤔
would it be better to use userEvent ? or in this case it doesn't make any difference?
There was a problem hiding this comment.
Yeah absolutely. Thanks Shayan. Also switched that screen. to using the result from the render, which I find more pure.
markw-deriv
force-pushed
the
add-tests-for-checkbox
branch
from
1836373 to
3b14bd2
Compare
shayan-deriv
approved these changes
Mar 11, 2024
|
🎉 This PR is included in version 1.10.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some unit tests for the Checkbox component.