[FEQ]Yaswanth/FEQ-1974_Added test cases for sidenote component #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matin-deriv
reviewed
Mar 25, 2024
matin-deriv
reviewed
Mar 25, 2024
matin-deriv
reviewed
Mar 25, 2024
matin-deriv
reviewed
Mar 25, 2024
Comment on lines
21
to
29
| it("renders children and title correctly", () => { | ||
| const { getByText } = render( | ||
| <SideNote title="Title"> | ||
| <div>Child content</div> | ||
| </SideNote> | ||
| ); | ||
| expect(getByText("Title")).toBeInTheDocument(); | ||
| expect(getByText("Child content")).toBeInTheDocument(); | ||
| }); |
There was a problem hiding this comment.
Certain variables such as title is being repeated and I suggest to define them in a beforeEach and reuse them in different tests.
There was a problem hiding this comment.
I couldn't use it in the beforeEach method because I've been using queryByText, getByText, and queryByTestId for specific cases.
shayan-deriv
approved these changes
Mar 26, 2024
|
🎉 This PR is included in version 1.12.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
yaswanth-deriv
deleted the
yaswanth/FEQ-1974_Added_test_for_sidenote_component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for side note component in deriv-com/ui library