Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: added gap between sideNote sections #143

Merged
merged 7 commits into from
Mar 29, 2024
Merged

style: added gap between sideNote sections #143

merged 7 commits into from
Mar 29, 2024

Conversation

shayan-deriv
Copy link
Contributor

changes:

  • added gap between title, content and action section
  • added titleClassname prop to enable the developer to override the styles for it
  • updated storybook

niloofar-deriv
niloofar-deriv approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@niloofar-deriv niloofar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 26, 2024 •
edited
Loading

Deploying deriv-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1520f2c
Status: ✅  Deploy successful!
Preview URL: https://295f9c53.deriv-ui.pages.dev
Branch Preview URL: https://shayan-feq-1987-fix-side-not.deriv-ui.pages.dev

View logs

@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8477356399

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.94%
Totals Coverage Status
Change from base Build 8477341138: 0.0%
Covered Lines: 106
Relevant Lines: 112
💛 - Coveralls

yaswanth-deriv
yaswanth-deriv approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@yaswanth-deriv yaswanth-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shayan-deriv shayan-deriv merged commit b4c276a into main Mar 29, 2024
3 checks passed
@shayan-deriv shayan-deriv deleted the shayan/feq-1987/fix-side-note-component-style-issue branch March 29, 2024 04:56
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.12.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsha-deriv utkarsha-deriv utkarsha-deriv left review comments

@amina-deriv amina-deriv amina-deriv approved these changes

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@yaswanth-deriv yaswanth-deriv yaswanth-deriv approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shayan-deriv @coveralls @amina-deriv @niloofar-deriv @yaswanth-deriv @utkarsha-deriv