Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] aum/FEQ-1579/PageLayout-component #19

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Jan 24, 2024

Changes

PageLayout Component

  • Layout component used in the cashier ( <PageContainer /> ) and the account-settings pages.
  • This is a three panel component which takes the content to be rendered as children and has left (optional) and right (optional) props to render items on the left and right side of the content.
  • In responsive view, we do not render the left panel (makes use of the useDevice hook to achieve this).

Screenshots

page__layout.mov

@aum-deriv aum-deriv changed the title [DRAFT] feat: ✨ added layout component [DRAFT] deriv-com/aum/layout Jan 24, 2024
useDevice: A custom hook to check for the client device and determine the layout to be rendered
useWindowSize: Used to grab the window size (same implementation as usehooks-ts)
@aum-deriv aum-deriv changed the title [DRAFT] deriv-com/aum/layout deriv-com/aum/layout Jan 25, 2024
@aum-deriv aum-deriv changed the title deriv-com/aum/layout deriv-com/aum/FEQ-1579/layout Jan 25, 2024
@aum-deriv aum-deriv changed the title deriv-com/aum/FEQ-1579/layout [FEQ] aum/FEQ-1579/layout Jan 25, 2024
@aum-deriv aum-deriv changed the title [FEQ] aum/FEQ-1579/layout [FEQ] aum/FEQ-1579/PageLayout-component Jan 26, 2024
@aum-deriv aum-deriv closed this Jan 26, 2024
@aum-deriv aum-deriv deleted the deriv-com/aum/layout branch January 26, 2024 10:15
@aum-deriv aum-deriv restored the deriv-com/aum/layout branch January 26, 2024 10:16
@aum-deriv aum-deriv reopened this Jan 26, 2024
@aum-deriv aum-deriv force-pushed the deriv-com/aum/layout branch from ecd6d23 to cc3a12d Compare January 26, 2024 13:37
@aum-deriv aum-deriv marked this pull request as ready for review January 29, 2024 07:28
@shayan-deriv
Copy link
Contributor

I'll resolve the conflict in a seperate PR

@shayan-deriv shayan-deriv merged commit dbf8bd7 into deriv-com:main Jan 30, 2024
1 check failed
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants