-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added functions to correct for extinction and v6 cuts #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
myamamoto26
commented
Dec 4, 2023
- Added functions to compute dereddened magnitudes.
- Added a function to add and change columns and save in a new file.
- Added V6 cuts (new i-band mag 24.5 cut, size cut, updated pgauss cut etc.) and new mask locations.
To-Do: adjust i-band magnitude cut. |
beckermr
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to double check a few items and write a few tests before we merge.
- figure out new i-band cut (from @myamamoto26's comment)
- write tests of new helper functions to compute asinh flux from mag etc.
- double check the asinh mag stuff is ok to use with the reddening stuff with Eli
beckermr
reviewed
Dec 5, 2023
beckermr
reviewed
Dec 5, 2023
I chatted with Eli and we need to apply the dereddening to the fluxes directly, not the lupton mags. |
beckermr
reviewed
Dec 12, 2023
beckermr
reviewed
Dec 15, 2023
beckermr
reviewed
Dec 15, 2023
beckermr
reviewed
Dec 15, 2023
beckermr
reviewed
Mar 21, 2024
beckermr
reviewed
Mar 21, 2024
beckermr
reviewed
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.