Merged
Conversation
✅ Deploy Preview for pythoness-programmer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| }, [selectedTag, router]) | ||
| if (searchQuery) { | ||
| params.set('search', searchQuery) | ||
| } |
There was a problem hiding this comment.
Bug: Empty Search Queries Break Filtering
The URL sync logic uses if (searchQuery) while the filter logic uses if (searchQuery.trim()), creating inconsistency. When searchQuery contains only whitespace, it gets added to the URL but doesn't filter any posts, showing a search parameter in the URL with no actual filtering applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds blog and resources search with URL-synced queries and refactors the resources page to a typed, data-driven component.
title,description, andtags.searchandtagfilters to URL; show result count and empty-state messaging.ResourcesListcomponent with client-side search acrosstitle,subtitle,description, andfeatures, plus result count/clear/empty states.src/types/resources.tsand resource data insrc/lib/resources.ts; wire intosrc/app/resources/page.tsx.README.mdto document blog/resources search and resources data management; update site sections list.public/feed.xmllastBuildDate.Written by Cursor Bugbot for commit b6bc21e. This will update automatically on new commits. Configure here.