-
Notifications
You must be signed in to change notification settings - Fork 373
Add The Nefarious Developer devcontainers to index #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @NickChecan , Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same. With Regards, |
Change request by @Kaniska244 to avoid issues with the ORAS spec
No problem at all @Kaniska244 . Thanks for the analysis and feedback. I made the change as requested. Let me know if anything else is needed from my side. |
|
Change approved. This can be merged. |
eljog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Please resolve conflicts
|
@Kaniska244 and @eljog conflicts were resolved. Can you please approve so it can be merged? |
AlvaroRausell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
What type of PR is this?
Related Issues
Description
Add devcontainer templates from the org The Nefarious Developer to the index.
Collection checklist
If your PR contributes a new collection, please utilize this checklist: