Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching registry library fails due to improper reference to index generator #1475

Closed
michael-valdron opened this issue Mar 11, 2024 · 5 comments · Fixed by devfile/registry-support#222
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@michael-valdron
Copy link
Member

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

Go project

Operating System and version: N/A

Go Pkg Version: 1.19

Bug Summary

Describe the bug:

When fetching chained dependencies for the registry library, the command fails due to the index generator dependency not pointing to a valid revision reference. This is because of replace redirection on v0.0.0 which does not work when referencing the module externally.

To Reproduce:

Run go get github.com/devfile/registry-support/registry-library@latest.

Expected behavior

Consumers should be able to successfully fetch the registry library module along with all dependencies of it.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

go: github.com/devfile/registry-support/index/[email protected]: reading github.com/devfile/registry-support/index/generator/go.mod at revision index/generator/v0.0.0: unknown revision index/generator/v0.0.0

Additional context

Any workaround?

Use earlier revisions of registry library which does not have this bug.

Suggestion on how to fix the bug

Change revision ref for index generator to latest one for both dependency reference and replace reference.

@michael-valdron michael-valdron self-assigned this Mar 11, 2024
@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Mar 11, 2024
@michael-valdron michael-valdron moved this to In Progress 🚧 in Devfile Project Mar 11, 2024
@michael-valdron
Copy link
Member Author

Using github.com/devfile/registry-support/index/generator v0.0.0-20240311135803-6215550f93d4 for index generator dependency reference.

@michael-valdron
Copy link
Member Author

PR is ready for review: devfile/registry-support#222

@michael-valdron
Copy link
Member Author

Confirmed these changes fix the fetching of the registry library under devfile/library.

@michael-valdron
Copy link
Member Author

Need to create a backport patch for 1.1.x for this bug.

@michael-valdron
Copy link
Member Author

v1.1.x backport fix PR ready for review: devfile/registry-support#223

@michael-valdron michael-valdron moved this from In Review 👀 to Done ✅ in Devfile Project Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant