Fix index generator reference under registry library #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
This was referenced Mar 11, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 7 7
Lines 2012 2012
=======================================
Hits 548 548
Misses 1417 1417
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
registry-library/fix-index-gen-ref
branch
from
cd6b069 to
faef096
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michael-valdron
added a commit
to michael-valdron/devfile-registry-support
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Michael Valdron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
registry-library
What does does this PR do / why we need it:
Fixes issue with fetching latest revisions of registry library on consumers.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1475
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: