-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Docker Compose Component #1134
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mahajanet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,3 @@ | |||
name: docker-compose | |||
dockerfile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be compose
?
type ComposeFileComponentLocation struct { | ||
|
||
// Type of Compose file Component Location | ||
|
||
LocationType ComposeFileComponentLocationType `json:"locationType,omitempty"` | ||
|
||
// Location uri of the docker-compose file | ||
|
||
Uri string `json:"uri,omitempty"` | ||
|
||
// Inline docker-file | ||
|
||
Inlined string `json:"inlined,omitempty"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove blank lines below documentation comments:
type ComposeFileComponentLocation struct { | |
// Type of Compose file Component Location | |
LocationType ComposeFileComponentLocationType `json:"locationType,omitempty"` | |
// Location uri of the docker-compose file | |
Uri string `json:"uri,omitempty"` | |
// Inline docker-file | |
Inlined string `json:"inlined,omitempty"` | |
} | |
type ComposeFileComponentLocation struct { | |
// Type of Compose file Component Location | |
LocationType ComposeFileComponentLocationType `json:"locationType,omitempty"` | |
// Location uri of the docker-compose file | |
Uri string `json:"uri,omitempty"` | |
// Inline docker-file | |
Inlined string `json:"inlined,omitempty"` | |
} |
This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
@yangcao77 this PR has also been tagged as stale. Do we want to get someone to take a look at it? |
@maysunfaisal this PR was opened just for POC, and is not ready for review, all tests are missing. |
What does this PR do?
There is now a docker-compose reference in Devfile which allows to provide an existing docker-compose file for the application definition. Created the component, wrote for validation and testing.
Link to Issue
#1120
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer