Skip to content

Create GitHub Issue Forms #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Apr 13, 2025

Description of Changes

Replaces current devfile issue templates with GitHub issue forms to simplify and streamline issue creation.

Related Issue(s)

resolves #1141

Acceptance Criteria

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

Tests Performed

Used fork to test issue creation and form validation.

How To Test

Pull changes into fork and switch fork default branch to branch with changes, ensure issues on fork repository is enabled.

Ensure your fork has the labels you want to test, CI applied labels won't work in the fork

Notes To Reviewer

N/A

Copy link

openshift-ci bot commented Apr 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/area api

@openshift-ci openshift-ci bot added the area/api Enhancement or issue related to the api/devfile specification label Apr 17, 2025
@michael-valdron
Copy link
Member Author

/area ci, /area documentation

@openshift-ci openshift-ci bot added the area/documentation Improvements or additions to documentation label Apr 17, 2025
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/ci,, area//area cannot be applied, because the repository doesn't have them.

In response to this:

/area ci, /area documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron michael-valdron removed area/documentation Improvements or additions to documentation area/api Enhancement or issue related to the api/devfile specification labels Apr 17, 2025
@michael-valdron
Copy link
Member Author

Will need to change the areas multi-choice dropdown to a textarea as putting the labeling commands separated by commas, a limitation with issue forms, will not trigger complete labeling as seen in my testing: #1703 (comment)

@michael-valdron
Copy link
Member Author

/area ci , /area api

@openshift-ci openshift-ci bot added area/ci area/api Enhancement or issue related to the api/devfile specification labels Apr 17, 2025
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/,, area//area cannot be applied, because the repository doesn't have them.

In response to this:

/area ci , /area api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron michael-valdron removed area/api Enhancement or issue related to the api/devfile specification area/ci labels Apr 17, 2025
@michael-valdron
Copy link
Member Author

/area api, ci

@openshift-ci openshift-ci bot added the area/ci label Apr 17, 2025
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/api, cannot be applied, because the repository doesn't have them.

In response to this:

/area api, ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron
Copy link
Member Author

Will need to change the areas multi-choice dropdown to a textarea as putting the labeling commands separated by commas, a limitation with issue forms, will not trigger complete labeling as seen in my testing: #1703 (comment)

Adding spaces does the trick #1703 (comment), however it still produces an error not ideal every time an issue is created.

@michael-valdron michael-valdron marked this pull request as ready for review April 17, 2025 16:22
@michael-valdron michael-valdron requested review from AObuchow, dkwon17 and a team as code owners April 17, 2025 16:22
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, also I can't open issues on your fork to see what each field is so if any suggestion doesn't make sense you can dismiss it (since I couldn't check)

@michael-valdron
Copy link
Member Author

also I can't open issues on your fork to see what each field is so if any suggestion doesn't make sense you can dismiss it (since I couldn't check)

@Jdubrick You'll need to pull changes into a branch in your fork and set it to the default if not already.

michael-valdron and others added 13 commits April 18, 2025 17:54
Bug Report

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Choose and fill in the applicable sections.

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Go Project

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Node.js Project

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Web Browser

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Target Odo Version

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Expected Behavior

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Additional Context

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Feature Request

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Additional Context

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Issue Details

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Emergency Registry Update

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Request Details

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, left only a comment in regards to the emergency registry promotion.

labels:
- area/registry
assignees:
- michael-valdron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good here to include all registry promoters? E.g we could create a specific team in devfile org and mention/ping the team if such request is received? WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, because the registry promoters are a sub-group of this team.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up here, though I think this would be a good idea, I don't believe you can add a GH organization team as an assignee. Closest solution here is that we can add registry promoters individually to all these issues, though the clean up of assignees might not be ideal, other solutions I can think of are:

  • To assign the registry service owner (currently myself, as I currently have it), I could re-assign to promoter on duty and best for getting noticed
  • No assignees, we'll have to manually assign the promoter on rotation after any of these are created

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up here, though I think this would be a good idea, I don't believe you can add a GH organization team as an assignee. Closest solution here is that we can add registry promoters individually to all these issues, though the clean up of assignees might not be ideal, other solutions I can think of are:

  • To assign the registry service owner (currently myself, as I currently have it), I could re-assign to promoter on duty and best for getting noticed
  • No assignees, we'll have to manually assign the promoter on rotation after any of these are created

I think you're right, I don't think there's a way to assign a gh org team. However, to clarify I meant to mention the gh org team in the issue description. This way all promoters get pinged, which could be of help in case some of us are off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta] Clean up issue templates in this repository
3 participants