-
Notifications
You must be signed in to change notification settings - Fork 65
Create GitHub Issue Forms #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area api |
/area ci, /area documentation |
@michael-valdron: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Will need to change the areas multi-choice |
/area ci , /area api |
@michael-valdron: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/area api, ci |
@michael-valdron: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adding spaces does the trick #1703 (comment), however it still produces an error not ideal every time an issue is created. |
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
4f8d4d1
to
174532f
Compare
Signed-off-by: Michael Valdron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, also I can't open issues on your fork to see what each field is so if any suggestion doesn't make sense you can dismiss it (since I couldn't check)
@Jdubrick You'll need to pull changes into a branch in your fork and set it to the default if not already. |
Bug Report Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Choose and fill in the applicable sections. Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Go Project Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Node.js Project Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Web Browser Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Target Odo Version Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Expected Behavior Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Additional Context Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Feature Request Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Additional Context Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Issue Details Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Emergency Registry Update Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
Request Details Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
0454389
to
a0cf3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general, left only a comment in regards to the emergency registry promotion.
labels: | ||
- area/registry | ||
assignees: | ||
- michael-valdron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good here to include all registry promoters? E.g we could create a specific team in devfile org and mention/ping the team if such request is received? WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, because the registry promoters are a sub-group of this team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow up here, though I think this would be a good idea, I don't believe you can add a GH organization team as an assignee. Closest solution here is that we can add registry promoters individually to all these issues, though the clean up of assignees might not be ideal, other solutions I can think of are:
- To assign the registry service owner (currently myself, as I currently have it), I could re-assign to promoter on duty and best for getting noticed
- No assignees, we'll have to manually assign the promoter on rotation after any of these are created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow up here, though I think this would be a good idea, I don't believe you can add a GH organization team as an assignee. Closest solution here is that we can add registry promoters individually to all these issues, though the clean up of assignees might not be ideal, other solutions I can think of are:
- To assign the registry service owner (currently myself, as I currently have it), I could re-assign to promoter on duty and best for getting noticed
- No assignees, we'll have to manually assign the promoter on rotation after any of these are created
I think you're right, I don't think there's a way to assign a gh org team. However, to clarify I meant to mention the gh org team in the issue description. This way all promoters get pinged, which could be of help in case some of us are off.
Description of Changes
Replaces current devfile issue templates with GitHub issue forms to simplify and streamline issue creation.
Related Issue(s)
resolves #1141
Acceptance Criteria
New testing and documentation issues can be opened under
devfile/api/issues
.You can check the respective criteria below if either of the following is true:
If criteria is left unchecked please provide an explanation why.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Tests Performed
Used fork to test issue creation and form validation.
How To Test
Pull changes into fork and switch fork default branch to branch with changes, ensure issues on fork repository is enabled.
Ensure your fork has the labels you want to test, CI applied labels won't work in the fork
Notes To Reviewer
N/A